Comments (3)
理论上可以通过 Category 在所有 dealloc
方法中都主动 unsubscribeAll
from glpubsub.
是的,修改方案有多种,我想应该放到GLPubSub中统一处理,你看下一下方法是否可行?
- (id)subscribe:(NSString *)eventName obj:(id)obj handler:(GLEventHandler)handler {
weak __typeof(self) weakSelf = self;
id observer = [[NSNotificationCenter defaultCenter] addObserverForName:eventName object:obj queue:_pubSubQueue usingBlock:^(NSNotification *note) {
if ( nil != weakSelf ) {
__strong typeof(weakSelf) strongSelf = weakSelf;
GLEvent *event = [[GLEvent alloc] initWithName:eventName obj:note.object data:[note.userInfo objectForKey:kGLPubSubDataKey]];
handler(event);
}
}];
NSMutableDictionary *subscriptions = (NSMutableDictionary *)objc_getAssociatedObject(self, &kGLPubSubSubscriptionsKey);
if (!subscriptions) {
subscriptions = [[NSMutableDictionary alloc] init];
objc_setAssociatedObject(self, &kGLPubSubSubscriptionsKey, subscriptions, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
}
NSMutableSet *observers = [subscriptions objectForKey:eventName];
if (!observers) {
observers = [[NSMutableSet alloc] init];
[subscriptions setObject:observers forKey:eventName];
}
[observers addObject:observer];
return observer;
}
from glpubsub.
用上面方法实现存在,通知一直没有被移除,执行block不在调用,在Category中调用主动 unsubscribeAll会更好,改方法有打算做Pod库的更新吗?
from glpubsub.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glpubsub.