Uninstalling installed files yields Cmake warnings about glfw

[gruelingpine185]

From what I understand, this is only a 3 character fix. I understand that isn't a pressing issue like the others, but it is an issue nonetheless. So may I fix this?

[dougbinks]

I'm a bit busy at the moment so will just write up some quick info:

I do wish to make a contribution to fix this, but I'm not sure which branch I should base the PR on. Should I do base it off of 3.3-stable since this is the branch I encountered it on or is there a preferred branch for minute things like this?

All PRs should be based off master.

And would a minor fix something like this warrant a change log entry and credits? If so awesome!

Normally yes, unless we think someone is Github credit farming.

Oh, and which branch should be used and what's the difference (or intent) behind master, latest, and 3.3-stable? It's always confused me.

We intend to document this but haven't' gotten around to it yet, here's a short summary:

• master (also called main which we may switch to in future) this is the primary development branch and should be used as the base for all PRs.
• latest gets updated to the most recent major, minor or patch release after each release.
• x.x-stable branched from its release tag on main, receives cherry-picked bug fixes for patch releases in parallel with the next minor or major release.

So may I fix this?

We welcome PRs but they do take time to get merged as there is a lot of outstanding work.

[gruelingpine185]

Thanks so much for your response. Sorry I was a little impatient. I'll make the PR and have it close this issue :)

[dougbinks]

No problem - however do leave this issue open until the PR is merged or this issue is otherwise resolved.

[gruelingpine185]

This turned out to be a little more than I can handle considering I do not know cmake very well. I have decided to let the the GLFW team (or anyone else) work on this issue. This is as far as I've gotten:

@@ -9,16 +9,16 @@ string(REGEX REPLACE "\n" ";" files "${files}")
 foreach (file ${files})
   message(STATUS "Uninstalling \"$ENV{DESTDIR}${file}\"")
   if (EXISTS "$ENV{DESTDIR}${file}")
-    exec_program("@CMAKE_COMMAND@" ARGS "-E remove \"$ENV{DESTDIR}${file}\""
-                 OUTPUT_VARIABLE rm_out
-                 RETURN_VALUE rm_retval)
+    execute_process(COMMAND CMAKE_COMMAND ARGS "-E rm \"$ENV{DESTDIR}${file}\""
+                    OUTPUT_VARIABLE rm_out
+                    RESULT_VARIABLE rm_retval)
     if (NOT "${rm_retval}" STREQUAL 0)
       MESSAGE(FATAL_ERROR "Problem when removing \"$ENV{DESTDIR}${file}\"")
     endif()
   elseif (IS_SYMLINK "$ENV{DESTDIR}${file}")
-    EXEC_PROGRAM("@CMAKE_COMMAND@" ARGS "-E remove \"$ENV{DESTDIR}${file}\""
-                 OUTPUT_VARIABLE rm_out
-                 RETURN_VALUE rm_retval)
+    execute_process(COMMAND CMAKE_COMMAND ARGS "-E rm \"$ENV{DESTDIR}${file}\""
+                    OUTPUT_VARIABLE rm_out
+                    RESULT_VARIABLE rm_retval)
     if (NOT "${rm_retval}" STREQUAL 0)
       message(FATAL_ERROR "Problem when removing symlink \"$ENV{DESTDIR}${file}\"")
     endif()

And it fails to delete the files, exiting with exit code 2: "No such file or directory" although it still exists.

---

Sources I looked at while trying to get this to work:

• https://cmake.org/cmake/help/latest/command/execute_process.html
• https://cmake.org/cmake/help/latest/variable/CMAKE_COMMAND.html
• https://cmake.org/cmake/help/latest/manual/cmake.1.html#cmdoption-cmake-E-arg-remove

[gruelingpine185]

I no longer see who put the message up with code that solved the issue, but whoever it was, thank you :)

[gruelingpine185]

I just ran it and it got rid of the warnings, but the files remain.

[ram-mohan]

I think this is the correct approach,

execute_process(COMMAND ${CMAKE_COMMAND} -E remove "$ENV{DESTDIR}${file}"
                OUTPUT_VARIABLE rm_out
                RESULT_VARIABLE rm_retval)

[gruelingpine185]

I can't try to figure it out right now, but I can try tomorrow and see if I have any success with it.