LSP: autocomplete does not take into account prefix about gleam

[dvic]

To add to this, what does work:

Type digits:

Select next suggestion:

[lpil]

Hello! This is a bug in the LSP specification unfortunately. How completions are applied is ambiguous in the spec so different editors do different things here. VS Code and Zed and Helix duplicate the module qualifier, others do not.

This feature is going to be rewritten to not use this part of the spec, but again unfortunately the LSP API that is not ambiguous requires a good deal more work to implement.

[dvic]

This feature is going to be rewritten to not use this part of the spec, but again unfortunately the LSP API that is not ambiguous requires a good deal more work to implement.

Clear. Out of curiosity, what part of the spec are we talking about here? Have you considered using https://github.com/elixir-tools/gen_lsp to handle the generic LSP stuff?

Edit: I see now that there is also an option Rust: https://github.com/ebkalderon/tower-lsp

[lpil]

That doesn't help with this problem in any way, and I think async Rust is not well suited to a language server as it is CPU bound and only has one client at a time. It adds a lot of complexity in exchange for nothing that I can see.

Implementing the protocol is quite trivial, it's just JSON RPC over stdio. It's the logic behind it that is the hard bit.

[dvic]

That doesn't help with this problem in any way, and I think async Rust is not well suited to a language server as it is CPU bound and only has one client at a time. It adds a lot of complexity in exchange for nothing that I can see.

Ah okay.

Implementing the protocol is quite trivial. It's the logic behind it that is the hard bit.

I'd like to help out with fixing this particular issue. Is there anything I can do? You mentioned that this feature is going to be rewritten to not use this part of the spec; is it now a bad time to have a look at this? Or is the mentioned rewrite something for the long-run and I can have a look at the issue now already with the existing codebase?

[lpil]

We need to move from the simple completion API to providing text-edits which delete the qualifier. No one has yet done any work on how we're going to determine what the edits are yet. Your help would be super appreciated!!