Coder Social home page Coder Social logo

Comments (2)

aidansteele avatar aidansteele commented on August 22, 2024

Hi @wparad, sorry I didn't see this until just now. I'm not sure I understand the threat - can you please demonstrate? I have an endpoint deployed at https://a0gy7ozvrj.execute-api.us-east-1.amazonaws.com/ with account ID 304520749683. Can you share the access key ID (i.e. the string beginning ASIA...) that you are able to retrieve?

(It's worth noting that this repo shouldn't be used anyway now that GitHub can issue OIDC tokens, but I'm still very curious to understand the vulnerability you describe)

from actions2aws.

wparad avatar wparad commented on August 22, 2024

Nope, I was totally wrong.

Initiall I thought it exposed the same vulnerability that https://www.vaultproject.io/docs/auth/github has, but it doesn't

All that are doing here, is same way all encrypted messages are sent usually, providing a public key, and having the service pull that and encrypt the credentials with it before sending it back. I was initially thinking that the either public key or the github token from the runner were being sent in the request, but since the service is pulling all this data, the only vulnerability here is DDoS on your endpoint.

That is my bad, I shouldn't have opened this.

from actions2aws.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.