internal links to element id's are not found about html-proofer

[DaleLJefferson]

Looks like it's this bit of code

# does the file even exist?
if link.remote?
   add_to_external_urls link.href
else
   self.add_issue "internally linking to #{link.href}, which does not exist" unless link.exists?
end

It's trying to see if the file '' exists, it should skip this check for internal links

[mprins]

I'm not sure but I think this started after a recent update (to 1.3.1 or 1.3.0), earlier builds did not give this problem eg. https://travis-ci.org/GeoDienstenCentrum/geodienstencentrum.github.io/builds/32709271

which I think would have been running v. 1.2.1

[DaleLJefferson]

Version 1.3.1 here

index.htm: internally linking to #q3, which does not exist
index.htm: internally linking to #q4, which does not exist
index.htm: internally linking to #q5, which does not exist
index.htm: internally linking to #q6, which does not exist
index.htm: internally linking to #q7, which does not exist
index.htm: internally linking to #q8, which does not exist
index.htm: internally linking to #q9, which does not exist
index.htm: internally linking to #q10, which does not exist
index.htm: internally linking to #q11, which does not exist
index.htm: internally linking to #q12, which does not exist
index.htm: internally linking to #q13, which does not exist
index.htm: internally linking to #q14, which does not exist
index.htm: internally linking to #q15, which does not exist
index.htm: internally linking to #q16, which does not exist
index.htm: internally linking to #q17, which does not exist
index.htm: internally linking to #q18, which does not exist
index.htm: internally linking to #q19, which does not exist
index.htm: internally linking to #q20, which does not exist
htmlproof 1.3.1 | Error:  HTML-Proofer found 22 failures!

[mprins]

definitely something that appeared after 1.2.1 (https://travis-ci.org/GeoDienstenCentrum/geodienstencentrum.github.io/builds/33591606)

[gjtorikian]

Strange, running that sample HTML file above locally does not produce the error for me.

[gjtorikian]

Cloning the repo, building the site, and running the same Travis command (htmlproof ./_site/ --favicon --verbose) does yield the error for me. So this will be fun. 😝

[doktorbro]

@gjtorikian Same here.

[doktorbro]

@dalejefferson Can you please provide more information about your case?

[gjtorikian]

Nope @penibelst I got a repro case. This is pretty bad. 😦 I might do a poor job explaining.

As noted above, the failure is here:

      if link.remote?
        add_to_external_urls link.href
      else
        self.add_issue "internally linking to #{link.href}, which does not exist" unless link.exists?
      end

When I set up the test case locally, the hash expands to
"/html-proofer/spec/html/proofer/fixtures/links/index.html", and it causes link.exists? to return true. Then, it proceeds down to actually look at the hash internally, and the test passes.

In the failure case, the link is expanded the same way, but because there's no index.html file, the test fails. This is actually correct--there's a bug in the way exists? depends on [absolute_path](https://github.com/gjtorikian/html-proofer/blob/88e1b201971bed2c01379e35de07e1fef76c1b77/lib/html/proofer/checkable.rb#L116).

In this case I think it would be best to skip checking whether the file exists if the link starts with a "#," since the hash check is later on down.

[doktorbro]

In this case I think it would be best to skip checking whether the file exists if the link starts with a "#," since the hash check is later on down.

@gjtorikian I agree.