node-gtk typings issues about ts-for-gir

[romgrk]

Indeed, our overrides here are missing the JSDoc to change the typings (opened #284).

[JumpLink]

Thanks you for your helpful feedback @romgrk 💚
I will look at it as soon as possible, hopefully in a few weeks.

[JumpLink]

@romgrk Unfortunately I have no time at the moment, maybe you can see if you can implement some of these things yourself?

[romgrk]

Sorry, no bandwidth for that :/ I might get around to it but I have more urgent issues to fix in node-gtk first.

[JumpLink]

Any updates in node-gtk @romgrk ?

[romgrk]

Still no time, the project has other bugs that are more important to fix and I've been having trouble getting around to them :/

[JumpLink]

@romgrk I hope I've fixed the points 2, 3, 4 and 6 now. Can you take a look at @types/node-gtk on my fork?

[romgrk]

I've taken a quick look, seems good overall :)

Fixing 5 would be awesome though. E.g. for Gtk, the methods signature usually take a Gtk.Widget, but we want child clasees (Gtk.Button, Gtk.Icon, ...) to fit in there so they need to inherit from Gtk.Widget.

[mildsunrise]

I think it hasn't been mentioned (& I still need to look at it) but APIs like setProperty are incorrectly marked as taking a GValue, the correct type would be any I think?

edit: also, this tool also seems to mark arrays of primitives as any

[mildsunrise]

Also to keep it in mind, the typings use Class.$gtype when it should be Class.prototype.__gtype__, but I'm not sure this was meant to be a public API, because it's missing on boxed objects (only available on actual instances).

[romgrk]

Not public, those are used for edge cases where there is not enough info in either GIR or Glib's gtype system about a boxed instance. They might be removed when I find a better way to handle them.

[mildsunrise]

In that case I suppose the best thing would be to add a public API at Class.$gtype to match gjs. It makes more sense than adding it on instances and the user can do instance.constructor.$gtype

[romgrk]

Yes, adding it on the constructor seems like the best place to add a public API for that. I don't really like the $ notation though. But let's open an issue on node-gtk for further discussion on this, it will save @sammydre from hearing our node-gtk internal discussions.

[JumpLink]

Theoretically all points should be solved now, if there are still issues please open a new issue, I am happy about feedback. :)