Coder Social home page Coder Social logo

Comments (5)

akosyakov avatar akosyakov commented on May 21, 2024

It's Theia bug, the preference widget should use the editor manager to open an editor, instead of trying to reimplement an editor opening himself: https://github.com/theia-ide/theia/blob/842196b5b18ce340f6b1beaea9e9a7ddbe2fd96f/packages/preferences/src/browser/preferences-tree-widget.ts#L193-L196

from gitpod.

paul-marechal avatar paul-marechal commented on May 21, 2024

I do not see the same code on master: https://github.com/theia-ide/theia/blob/master/packages/preferences/src/browser/preferences-tree-widget.ts#L99-L113

I am kind of confused.

Although if this is a Theia problem, would it make sense to report it on the issue tracker?

Because if you feel confident that this is not a gitpod issue we can close this ticket, as it might be better to continue on the Theia repo.

from gitpod.

akosyakov avatar akosyakov commented on May 21, 2024

Yes, I'm pretty sure, the internal contract was changed, the editor factory excepts an object, no a URI. But it is all implementation details, clients should just always use EditorManager.

from gitpod.

akosyakov avatar akosyakov commented on May 21, 2024

Will be resolved with eclipse-theia/theia#2615

from gitpod.

akosyakov avatar akosyakov commented on May 21, 2024

it was resolved already

from gitpod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.