Post-merge review of #3356 about vscode-gitlens

[sergeibbb]

@eamodio

Suggest changing the notion of "secret" to "session"/"stored session"/"auth":

I'm taking "auth". I pick anything but "session", because there is a layer of "[actOn]Session" methods that call to "[actOn]Secret" methods (that are kind of a lower level), that's why I took a different word for that.

[sergeibbb]

@eamodio

Restrict the key params to be a subset of SecretKeys to avoid something else getting in there

Do you mean adding a check on its value at runtime?

[eamodio]

@eamodio

Restrict the key params to be a subset of SecretKeys to avoid something else getting in there

Do you mean adding a check on its value at runtime?

More to just create a restricted type, e.g.

export type SecretKeys =
	| `gitlens.${AIProviders}.key`
	| `gitlens.plus.auth:${Environment}`
	| IntegrationAuthenticationKeys;

export type IntegrationAuthenticationKeys =
	| `gitlens.integration.auth:${IntegrationId}|${string}`
	| `gitlens.integration.auth.cloud:${IntegrationId}|${string}`;

And then use that new type

[sergeibbb]

More to just create a restricted type

ok. that's clear