Cannot read property 'sha' of undefined about vscode-gitlens

[eamodio]

I think I have finally resolved this in the latest version.

[eamodio]

@nonameolsson can you set gitlens.advanced.output.level = verbose and gitlens.advanced.debug = true, and then send me the output from the GitLens output pane when the error occurs?

[nonameolsson]

@eamodio Thanks, will do!

[Tyriar]

I'm seeing this as well. It happens when settings.json is focused. This is a pretty common use case to open files that do not below to any git repository so it should be handled gracefully 😃

[Extension Host] [GitLens] getBlameForFile('/home/daniel/.config/Code - Insiders/User/settings.json', undefined, undefined)

CodeLens config changed; resetting CodeLens provider
getBlameForFile('/home/daniel/.config/Code - Insiders/User/settings.json', undefined, undefined)
Add blame cache for '/home/daniel/.config/code - insiders/user/settings.json'
git blame --root --incremental -- settings.json   cwd='/home/daniel/.config/Code - Insiders/User' 
  Error: fatal: Not a git repository (or any of the parent directories): .git  Failed with exit code: 128
Replace blame cache with empty promise for '/home/daniel/.config/code - insiders/user/settings.json'
Clear cache entry for '/home/daniel/.config/code - insiders/user/settings.json', reason=DocumentSaved
CodeLens config changed; resetting CodeLens provider
getBlameForFile('/home/daniel/.config/Code - Insiders/User/settings.json', undefined, undefined)
Add blame cache for '/home/daniel/.config/code - insiders/user/settings.json'
git blame --root --incremental -- settings.json   cwd='/home/daniel/.config/Code - Insiders/User' 
  Error: fatal: Not a git repository (or any of the parent directories): .git  Failed with exit code: 128
Replace blame cache with empty promise for '/home/daniel/.config/code - insiders/user/settings.json'
getBlameForFile('/home/daniel/dev/sourcelair/xterm.js/package.json', undefined, undefined)
Add blame cache for '/home/daniel/dev/sourcelair/xterm.js/package.json'
git blame --root --incremental -- package.json   cwd='/home/daniel/dev/sourcelair/xterm.js'
getBlameForFile('/home/daniel/.config/Code - Insiders/User/settings.json', undefined, undefined)
getBlameForFile('/home/daniel/.config/Code - Insiders/User/settings.json', undefined, undefined)
getBlameForFile('/home/daniel/.config/Code - Insiders/User/settings.json', undefined, undefined)

[eamodio]

@Tyriar You are seeing the same Cannot read property 'sha' of undefined? With the same stack trace? I can't reproduce this issue - I can go through the same steps and produce practically the same output log you posted, but I never see that error (things are handled gracefully).

Is it always reproducible?

[Tyriar]

It seemed always reproducible. Note I was on the insiders build.

[eamodio]

Hrm -- I'm running today's insiders too. Can you try this build gitlens-1.4.2.zip -- I've added some more logging to trap when this happens.

(Just need to rename it back to *.vsix -- github wouldn't let me upload it otherwise)

[Tyriar]

No reproducing now, it's probably worth adding some more defensive checks though.

[eamodio]

@nonameolsson are you still experiencing this issue?

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.