Comments (7)
Done with c6baebe. Thank you again!
from yellow-comment.
Regarding the value exclude
: right, I will change it.
Regarding the key Comment
, just a little doubt: in my intention, Comments
is not a plural per se, but simply the name of the extension. So for example I would find it more natural and easy to remember if also in yellow-disqus
the setting were named Disqus
instead of Comment
.
But if Comment
fits better in the conventions of Yellow, I will change it 😊
from yellow-comment.
Perhaps change the name of the extension and the setting to Comment
?
It makes life easier to stick to singular. You don't have to think every time, what was the name again, should I put a letter 's' at the end this time? I see inconsistency as one of the biggest contributor to development waste. It occupies time to understand how different parts of a system fit together, even more time if they need to be changed in order to work well together. Let's take for example something common like Title
and Tag
. The title of a page can only be singular, here it's easy. The tag(s) on a page can be singular and plural. What should you do when you first have one tag and add another one, do you change your setting from Tag
to Tags
? Perhaps your preference/opinion would change in another context, but in order for extensions to work together, we need one agreed name. It makes life easier for developers. This is were the naming convention originated from.
from yellow-comment.
Perhaps change the name of the extension and the setting to Comment?
Good idea, I will do that!
from yellow-comment.
Thank you. Then the blog layout should be changed too, change getExtra()
arguments to singular to match?
from yellow-comment.
Also done, extensions should be working together again.
from yellow-comment.
Perfect, thank you very much!
from yellow-comment.
Related Issues (20)
- Blog and blogpage snippets not compatible with Yello 0.7.1 HOT 26
- Names of developers HOT 2
- Use shared content folder for new comment template HOT 2
- Comments: 0 Comments are closed. HOT 4
- How to use this? HOT 19
- Where are the published comments stored? HOT 1
- Comments disappear after being published HOT 1
- How to customise the text HOT 1
- Plugin installation / execution fails HOT 14
- language text file issue HOT 1
- foreach() argument must be of type array|object HOT 1
- FILTER_SANITIZE_STRING is deprecated in PHP 8.1 HOT 1
- Comment showing under main Blog page HOT 2
- [Error] Deprecated: Creation of dynamic property YellowComment::$comments HOT 3
- Unpublished comments show up in search results HOT 3
- All comments are filed twice HOT 4
- fatal error when comments published HOT 6
- Comments order HOT 4
- Comment count HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yellow-comment.