Coder Social home page Coder Social logo

Comments (7)

GiovanniSalmeri avatar GiovanniSalmeri commented on June 8, 2024 1

Done with c6baebe. Thank you again!

from yellow-comment.

GiovanniSalmeri avatar GiovanniSalmeri commented on June 8, 2024

Regarding the value exclude: right, I will change it.

Regarding the key Comment, just a little doubt: in my intention, Comments is not a plural per se, but simply the name of the extension. So for example I would find it more natural and easy to remember if also in yellow-disqus the setting were named Disqus instead of Comment.

But if Comment fits better in the conventions of Yellow, I will change it 😊

from yellow-comment.

markseuffert avatar markseuffert commented on June 8, 2024

Perhaps change the name of the extension and the setting to Comment?

It makes life easier to stick to singular. You don't have to think every time, what was the name again, should I put a letter 's' at the end this time? I see inconsistency as one of the biggest contributor to development waste. It occupies time to understand how different parts of a system fit together, even more time if they need to be changed in order to work well together. Let's take for example something common like Title and Tag. The title of a page can only be singular, here it's easy. The tag(s) on a page can be singular and plural. What should you do when you first have one tag and add another one, do you change your setting from Tag to Tags? Perhaps your preference/opinion would change in another context, but in order for extensions to work together, we need one agreed name. It makes life easier for developers. This is were the naming convention originated from.

from yellow-comment.

GiovanniSalmeri avatar GiovanniSalmeri commented on June 8, 2024

Perhaps change the name of the extension and the setting to Comment?

Good idea, I will do that!

from yellow-comment.

markseuffert avatar markseuffert commented on June 8, 2024

Thank you. Then the blog layout should be changed too, change getExtra() arguments to singular to match?

from yellow-comment.

markseuffert avatar markseuffert commented on June 8, 2024

Also done, extensions should be working together again.

from yellow-comment.

GiovanniSalmeri avatar GiovanniSalmeri commented on June 8, 2024

Perfect, thank you very much!

from yellow-comment.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.