Comments (1)
The problem is that OneChart uses the robustName
function both in resource names (can't have dots in them) and for ingress hostname (naturally they have dots).
Solution 1
- replace dots with dashes in
robustName
- don't use
robustName
in ingress hostnames
pro: OneChart will be resilient to variable driven resource names like myapp-$BRANCH
where $BRANCH=dependabot/npm_and_yarn/ws-5.2.3
con: ingress hostnames have to be sanitized by the end user:
app: myapp-{{ .GITHUB_BRANCH }}
appAlias: myapp-preview
env: local
namespace: default
chart:
repository: https://chart.onechart.dev
name: onechart
version: 0.24.0
values:
ingress:
host: myapp-{{ .GITHUB_BRANCH | sanitizeDNSName }}.mycompany.com
Solution 2
- replace dots with dashes in
robustName
- use a new
robustHostName
in ingress hostnames that allows dots
pro: OneChart will try to protect the user from common issues
con: domain names will look like myapp-dependabot-npm-and-yarn-ws-5.2.3.mycompany.com
in the above example. This is multiple level of subdomains, not something we should do
from onechart.
Related Issues (20)
- [charts/onechart] add hostNetwork HOT 1
- Add `merge` and `patch` fields
- Investigate if OneChart can be rendered to Cloud Run / KNative serving API HOT 2
- Init container support HOT 3
- policy/v1beta1 is deprecated in k8s 1.25
- No way to mount Single FIle. HOT 5
- Chart version v0.41.0 does not seem to have existingFileSecrets changes HOT 1
- Adding promtheus scraping? HOT 3
- Allow the possibility to not set limits.
- License HOT 1
- No way to mount single file from secret
- Publish Onechart to an OCI registry HOT 2
- Ability to reference existing configmaps and secrets
- Support ExternalSecrets HOT 1
- args not supported HOT 1
- multiple ingress - paths HOT 1
- Support using file configmap and avoiding custom command on CronJob
- Request for HPA Support Contribution HOT 1
- [charts/onechart] Specifying ports in values doesn't work as expected HOT 2
- Add ingress.pathType
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onechart.