robustName should not allow `.` about onechart

[laszlocph]

The problem is that OneChart uses the robustName function both in resource names (can't have dots in them) and for ingress hostname (naturally they have dots).

Solution 1

• replace dots with dashes in robustName
• don't use robustName in ingress hostnames

pro: OneChart will be resilient to variable driven resource names like myapp-$BRANCH where $BRANCH=dependabot/npm_and_yarn/ws-5.2.3
con: ingress hostnames have to be sanitized by the end user:

app: myapp-{{ .GITHUB_BRANCH }}
appAlias: myapp-preview
env: local
namespace: default
chart:
  repository: https://chart.onechart.dev
  name: onechart
  version: 0.24.0
values:
  ingress:
    host: myapp-{{ .GITHUB_BRANCH | sanitizeDNSName }}.mycompany.com

Solution 2

• replace dots with dashes in robustName
• use a new robustHostName in ingress hostnames that allows dots

pro: OneChart will try to protect the user from common issues
con: domain names will look like myapp-dependabot-npm-and-yarn-ws-5.2.3.mycompany.com in the above example. This is multiple level of subdomains, not something we should do