jQuery dependency about tilt.js

[micku7zu]

Hi Guys, I hope @gijsroge won't be upset. I initially wanted to make a fork and improve the actual jQuery code (mostly to cache things) and then make a pull request, but then I saw that many of you wanted a vanilla version, without any dependencies so I started a new project which is a shameless copy of @gijsroge work but without jQuery.

Here you can find the vanilla version: https://micku7zu.github.io/vanillaTilt.js/index.html

@gijsroge I don't need any credits about the vanilla version, if you want to include it in your project and maintain it, I will be happy to delete my own project and help / write code on your project, just contact me 😄

[joshwcomeau]

@gijsroge I think you might be surprised at how far vanilla JS has come :) comparing the two versions, the jQuery one is not any more maintainable.

For comparison: Tilt.js and vanillaTilt.js

(full code is available here: https://github.com/micku7zu/vanillaTilt.js)

If you're comfortable in jQuery, it's totally understandable that you wouldn't feel the need to change the codebase. That said, I think it behooves you to take another look at ditching jQuery, in this and your work in general; IMO it's becoming a pointless abstraction as browser compatibility and browser APIs improve, and you don't want to be bundling a big library if you don't have to.

[gijsroge]

@micku7zu Thanks for the amazing effort! Looks really solid.

I'm not fond of including this in my library as it would only increase the time to maintain/write tests etc.
I do think you should start your own repo, and i'll happily link that one in my readme :)

Also if you start your own repo, leave a reply here for future visitors that are looking for a vanilla version :)

Thanks again!

[garygreen]

@gijsroge shame you won't accept a PR to remove jquery as a dependency. jQuery is increasingly becoming more obsolete with libraries like vue.js, react, etc and browser's becoming more and more similar without their nuances, it's almost pointless including it - in fact, my website doesn't use jquery at all and so tilt.js just isn't worth it, if I have to include jQuery as well.

There's really only a win win for removing jQuery as dependency imo, but of course it's your call. 😄

[lucasbento]

I was wondering the same, really liked your job here, @gijsroge, wanted to use it with React but without jQuery.

[micku7zu]

@gijsroge Thanks. I appreciate what kind of person you are 👍 Keep up the good work man!

Ok, so now that we know the directions of both projects, I will have to do some more work on my own repository, because it was all just a messy copy & paste.

I will credit you and your project everywhere I can in my repository, because people should know that a jQuery version is present and it was the original idea of the effect 😄

I will contact you after the repository will be polished and if you want, you can include somewhere in the Readme.

I will try to keep the API/options/features very similar with yours :)

Good job again,
Have a nice day all!

[gijsroge]

@marcobiedermann Its your lucky day cause @micku7zu has already wrote a vanilla js version -> https://github.com/micku7zu/vanillaTilt.js

[gijsroge]

I'm not sure, I wouldn't count on it. I'll update this issue if I change my mind.

Oh and thanks for the compliment! 😄

[larrybotha]

There's nothing major in here that couldn't be nicely abstracted using vanilla JS to eliminate the jQuery dep :)

Pretty much need the following, and jQuery can be eliminated:

• helper for applying css props
• helper for checking for data attributes
• helper for getting event co-ordinates
• a few custom events to trigger

Would love to get on this, but can't dedicate any time at the moment :/

Would also be beneficial to convert this to a UMD module.

Anyways, great job, awesome effect :)

[lucasbento]

Loved the work, @micku7zu!

I think it would be great if you included it on the README, @gijsroge.

Great job, guys! 😄

[gijsroge]

@joshwcomeau Yes I know, i did some work in vanilla JS, but I felt like doing something with jQuery as people are more familliar with it. But i agree this could easily be done in vanilla JS. But I don't want to change the whole codebase in this repo after 2 days :)

[garygreen]

Also, you could still use jquery to write tests, if you like.

[marcobiedermann]

@gijsroge
Any updates on this one?
I would also like to use tile.js without jQuery.
Translating your code to vanilla JS should not be too hard with modern JavaScript.
I suggest adding a jQuery wrapper in a separate file so still support both options.
If you like, I can help you out and provide a PR.

[marcobiedermann]

@gijsroge
I've already seen this comment (#1 (comment)). But I don't think it makes any sense to create a separate repo for this.
Makes maintaining and implementing features / bugfixes way harder and will always be out of sync.
My question was if you / your project is interested in moving over to a vanilla approach :)