Found a WAV file that doesn't play about gdscriptaudioimport

[pixelriot]

I've done some testing, and it seems as if wav files with 24 bps don't play properly, while the ones with 16 bps have no problem.
Maybe that helps in finding the bug.
I will continue my research.

[Gianclgar]

Hi, could you try to send/post the file via a third party service? I recommend https://tmp.ninja/ since it has a 10gb limit.

Looks like an error in the parsing, since it expects the wav files to have the same structure. This could help to adapt the parsing to different pre-data chunk sizes, so it will be very helpful

[Dimev]

Ah right I have mega, l'll share it via there
I do think it has to do with the header. I also tried porting the built-in parser to gdscript but that's really slow

[Dimev]

It seems to sometimes happen with music downloaded as wav with youtubedl

re-exporting it with audacity fixes the issue

[Gianclgar]

I've done some testing, and it seems as if wav files with 24 bps don't play properly, while the ones with 16 bps have no problem.
Maybe that helps in finding the bug.
I will continue my research.

Makes sense since the bitrate is not handled in the current version, just printed out. See lines 118 and 119. I added a "TODO" in the comments

Also, as mentioned in #7 , the format code "3" , which seems to be for 24bit audio is not handled yet.

[pixelriot]

When loading the 24bps wav file directly into a Godot AudioPlayer node everything plays fine, although the stream in GD source code seems to not handle format code "3": https://github.com/godotengine/godot/blob/master/scene/resources/audio_stream_sample.cpp#L368

[Gianclgar]

Yup, I've been checking the Godot ResourceImporter code, and it automatically converts bitrates greater than 16bit to 16bit. See lines 289 and below https://github.com/godotengine/godot/blob/a02620f3a5f3b94c68dfbe18874b34ac1c32374a/editor/import/resource_importer_wav.cpp

The file mentioned in #7 is 32bit and when imported with the built-in resource importer it's converted to 16bit.

I assume they did not cover this since they expected users to always use the built-in resource importer

[Gianclgar]

This might have been fixed by #13 . Awaiting confirmation!

[pixelriot]

Works like a charm. Nearly my whole wav-library can be played back now. Thanks a lot.

However, I found some that don't play. Somehow, the data-part of "those4bytes" seems empty.
https://drive.proton.me/urls/FDQ71VN5WC#zIZqoIAFgZ1n