Comments (11)
In an effort to keep this library lightweight and simple, have decided not to implement this feature. If there is a rising demand for this, am open to consider this again.
Thanks for your patience and understanding guys.
from micromodal.
Being able to pass an element as modal would also make this great library work inside of web-components.
Otherwise you'll just get a
Uncaught TypeError: Cannot read property 'setAttribute' of null
at Modal.showModal (micromodal.es.js:138)
I guess a simple this.modal = typeof targetModal === "string" ? document.getElementById(targetModal) : targetModal
would already solve this issue.
from micromodal.
I push this because I need that feature too for my web components. Is there maybe any new informations?
from micromodal.
Is this still on the radar?
from micromodal.
@ghosh, I can confirm that changing this one line (https://github.com/ghosh/Micromodal/pull/351/files) allows the library to be used in web components.
from micromodal.
any updates on this issue?
from micromodal.
please any updates on this ?
from micromodal.
Bumping this as well. Not a big change.
from micromodal.
Another bump, if this library doesn't support shadow dom then I can't use it for the project I am working on. Which is a shame, because it is forward-looking with no dependencies and es6 module support.
from micromodal.
Just as a reminder, I have my PR #351 running in production since July 2020 without any issues in our web components.
from micromodal.
Any news or considerations on this, @ghosh?
from micromodal.
Related Issues (20)
- Modals closing unexpectedly with any interaction HOT 3
- modal input label is triggering other input fields on the main page HOT 2
- Breaking change in 0.4.9: clicking the container closes the modal HOT 8
- Modal reopens after closing
- hi
- target argument is getting the parent on Safari. OnShow method. HOT 3
- Tab trapping does not work in Safari HOT 1
- onClose event is not triggered when clicking on the modal overlay HOT 7
- Window object doesn't work during gatsby build. HOT 1
- Feature idea: "non-dismissable" option HOT 1
- Esc and focus trap does not work if iframe is inside the modal HOT 3
- Modal closes when selecting a field. HOT 5
- Micromodal js not working on IOS devices HOT 5
- Add option to control whether disable Escape to close modal HOT 3
- Slick Slider HOT 1
- Nested modals don't close properly via JS api HOT 1
- Is this still being maintained? HOT 3
- Click Function For Element inside Modal Generates Error HOT 1
- "awaitCloseAnimation: true" does not sum the duration of all animations.
- Hard to intigrate in HTML HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from micromodal.