Gray text invisible about hyper-solarized-dark

[tad-lispy]

Thank you @ghosh. I really like your theme.

Locally I've set the colour to #586e75, which is what Solarized Dark theme for Atom Editor uses for comments. See here (@base01) and here (@syntax-comment-color).

It looks pretty nice.

[raphaelproux]

Hi, I would like to bring this issue up since it has been reversed by commit 3a71436
The current version has this invisible text issue again.

[ghosh]

@lzrski @laedit Thank you for bringing this to notice. I will fix it soon. 👍

[tad-lispy]

Maybe there should be a unit test? Something like: for each color assert that it is not the same as background color. You could even consider using something like https://github.com/bgrins/TinyColor#readability 😄

[ghosh]

@jswny I would happily accept a PR to fix this.

[ghosh]

@jswny Thank you. Released in 0.1.6

[laedit]

Grey is also used for short param in powershell, like -r.

[ghosh]

@lzrski Thanks, that helped!

[jswny]

I can confirm that this issue appears again because of commit 3a71436 as noted by @raphaelproux . Manually reversing the change in this commit in the local plugin index.js file fixes the issue.

@ghosh Can we get an update on why this issue was re-introduced and how to go about fixing it?

[jswny]

@ghosh Sent! Cheers :)