Problem with scandir on ReiserFS about the_silver_searcher

[ggreer]

Thanks for creating an issue. This sounds like a bug in Reiser FS, but it's likely that other filesystems are broken in this way. I don't have an system on which to try and reproduce, so I'll need your help confirming the fix. I'm pretty busy, but I should have something for you to try out within the next week.

[IanMReed]

Happy to help.

I've ended up with some code like this in search.c when looping through the results of scandir:

    if(dir->d_type == DT_UNKNOWN) {
            if(-1!=lstat(dir_full_path, &stDirInfo))
            {
                    if(S_ISDIR(stDirInfo.st_mode)) {
                            dir->d_type=DT_DIR;
                    }
                    else if (S_ISLNK(stDirInfo.st_mode)) {
                            dir->d_type=DT_LNK;
                    }
            }

            if (!opts.follow_symlinks && dir->d_type == DT_LNK) {
                    log_debug("File %s ignored becaused it's a symlink", dir->d_name);
                    goto cleanup;
            }
    }

I looked at having a variation of this code in filename_filter but as I understand it we don't have the full path there so calling lstat will be problematic. NOTE: Haven't tested the symlink check is working as expected.

[ggreer]

You have code? This pleases me greatly. I'd love it if you could submit a pull request to get credit for your work (and show up in the git blame output).

[IanMReed]

Will do - once I work out how to drive git.

[ggreer]

Fixed by @IanMReed in #37.