Comments (6)
Dear @psanan
You are correct. Now we explicitly say that Mandyoc is a 2-D code in the JOSS paper.
from mandyoc.
Re several of the points above, I strongly agree that the submission is missing information and citations to position itself relative to other pieces of free and/or open source software which solve similar problems. Strict novelty is not a requirement for publication, but it's important for readers to know what differentiates this code from others they may have used or read about, both in terms of the physical problems it solves (in particular, with regards to surface processes) and in terms of the practical usage of the software.
Re point 3, I think that the template is a little confusing in mixing literal section headings with section headings that describe how to format things ("Mathematics", "Citations", "Figures") that don't need to be literally included.
Re Point 4, I would argue that the choice of example to include is fine, especially given that the van Keken benchmark is nicely presented in your documentation, this benchmark is presumably identical to the one in examples/
, and this example does a good job of showing a reproducible experiment quite similar to ones other researchers might want to run with the code.
from mandyoc.
The paper was updated following the suggestions of the reviewers:
- The
Statement of Need
was improved, also citing other codes with similar functionalities. - The information related to
Statement of Field
is presented along withStatement of Need
. - Additional references were included relative to previous works showing the integration between surface processes and Earth's interior dynamics.
- We preferred to preserve the example of continental rifting because this scenario presents a complex non-linear rheology, what we believe to be an attractive for future users. Other examples of numerical scenarios are presented in the documentation.
Addresses Issue #54.
from mandyoc.
My concerns have been addressed wrt this issue, so consider my comment above "resolved".
from mandyoc.
One further minor comment on the paper (and documentation in general). As far as I can tell, it is never explicitly stated anywhere that this is a 2D-only code, even though in the paper it's compared to codes which support 3D simulations. That's a crucial piece of information for potential users and should be stated clearly. If a potential user needs to perform a 3D simulation, they obviously cannot use Mandyoc and should be directed elsewhere quickly, but otherwise a smaller and more contained (hence potentially easier to understand and modify) 2D-focused code might be just what they're looking for.
from mandyoc.
Looks OK to me. I am closing this.
from mandyoc.
Related Issues (20)
- JOSS REVIEW: Tests HOT 2
- Makefile - broken variable name for the installation
- Segmentation Violation related to particles swarm
- Minor points on the installation instructions
- JOSS REVIEW: clarification of support for nonlinear rheology HOT 3
- Improve if conditionals and set a default case to evaluate viscosity in calc_visc
- Compilation warnings due to conditionally defined values
- sticky_blanket_air in surface processes
- fix gravity values
- Docs for 3D version
- Wrong parse of "-seed" and "-strain_seed" command values
- Mandyoc is not beeing build in Dockerfile
- Typo in tests/run_tests.sh
- Abort if periodic_boundary is active in 3D mode (not supported yet)
- Wrong check of number of layers from -seed command and interfaces file
- Typo "/n" in Makefile
- Random number generation
- fix deprecations in tests
- Output the command used to execute mandyoc in the log
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mandyoc.