Feature request: Custom attachments about stream-chat-android

[tschellenbach]

see #107

[tschellenbach]

You can add custom data when creating an attachment and it will end up in attachment.extraData. Does that work for your use case or do you need to add methods to the attachment object?

…

On Tue, Sep 3, 2019, 15:34 Łukasz Nowak ***@***.***> wrote: Hi! Is there any chance to add support for custom attachments? The Attachment class seems like it can't handle anything extra and I need at least one extra field there now. It's pretty much the same issue that was solved for the iOS sdk few days ago: GetStream/stream-chat-swift#4 <GetStream/stream-chat-swift#4> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#28?email_source=notifications&email_token=AACAZQOIBIJIQY236YR2STTQHZKWBA5CNFSM4ITFX7L2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HI7DV7Q>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACAZQOLDHUTVAOJ2BEO63TQHZKWBANCNFSM4ITFX7LQ> .

[luknow93]

Yeah I think adding only that extraData field would be enough as long as anything custom will end up there :)

[luknow93]

While we're at it, similar thing could be added to Message object. I see iOS already has it, and we're using it there

[tschellenbach]

Yeah, it's private on the message object atm. Will update once this is resolved.

[tschellenbach]

// message and channel have extra data getters and setters
message.setExtraData
channel.setExtraData

@tbarbugli we currently don't have this on the attachment, can you have a look?

[luknow93]

I tried to send some extraData attached to Message. But it seems like its not being sent?
In Channel.java extraDtya is not passed to SendMessageRequest at all. Unless I'm missing something?

public void sendMessage(Message message,
                            MessageCallback callback) {
        List<String> mentionedUserIDs = Utils.getMentionedUserIDs(channelState, message.getText());
        SendMessageRequest request;
        if (message.getId() != null) {
            request = new SendMessageRequest(message.getId(), message.getText(), message.getAttachments(), message.getParentId(), false, mentionedUserIDs);
        } else {
            request = new SendMessageRequest(message.getText(), message.getAttachments(), message.getParentId(), false, mentionedUserIDs);
        }

        client.sendMessage(this, request, new MessageCallback() {
            @Override
            public void onSuccess(MessageResponse response) {
                if (callback != null)
                    callback.onSuccess(response);
            }

            @Override
            public void onError(String errMsg, int errCode) {
                if (callback != null)
                    callback.onError(errMsg, errCode);
            }
        });
    }

I tried to add extra data while intercepting the message being sent by MessageInputView, and then passing it to ChannelViewModel as MessageInputView would do by default.
Is this the correct approach?

val viewModel = ViewModelProviders.of(this@MyFragment, ChannelViewModelFactory(activity!!.application, channel)) 
                    .get(ChannelViewModel::class.java)
ready__message_input.setViewModel(viewModel, this)

//...

ready__message_input.setOnSendMessageListener(object : MessageInputView.SendMessageListener {
                override fun onSendMessage(message: Message, callback: MessageCallback?) {
                    val extra = message.extraData ?: HashMap<String, Any>()
                    extra["testkey"] = "testvalue"
                    message.extraData = extra

                    viewModel.onSendMessage(message, callback) //ChannelViewModel
                }
            })

[tschellenbach]

Support for this is in master branch at the moment. Few more days till it goes live.

…

On Wed, Oct 2, 2019, 23:35 Łukasz Nowak ***@***.***> wrote: I tried to send some extraData attached to Message. But it seems like its not being sent? In Channel.java extraDtya is not passed to SendMessageRequest at all. Unless I'm missing something? public void sendMessage(Message message, MessageCallback callback) { List<String> mentionedUserIDs = Utils.getMentionedUserIDs(channelState, message.getText()); SendMessageRequest request; if (message.getId() != null) { request = new SendMessageRequest(message.getId(), message.getText(), message.getAttachments(), message.getParentId(), false, mentionedUserIDs); } else { request = new SendMessageRequest(message.getText(), message.getAttachments(), message.getParentId(), false, mentionedUserIDs); } client.sendMessage(this, request, new MessageCallback() { @OverRide public void onSuccess(MessageResponse response) { if (callback != null) callback.onSuccess(response); } @OverRide public void onError(String errMsg, int errCode) { if (callback != null) callback.onError(errMsg, errCode); } }); } I tried to add extra data while intercepting the message being sent by MessageInputView, and then passing it to ChannelViewModel as MessageInputView would do by default. Is this the correct approach? val viewModel = ***@***.***, ChannelViewModelFactory(activity!!.application, channel)) .get(ChannelViewModel::class.java) ready__message_input.setViewModel(viewModel, this) //... ready__message_input.setOnSendMessageListener(object : MessageInputView.SendMessageListener { override fun onSendMessage(message: Message, callback: MessageCallback?) { val extra = message.extraData ?: HashMap<String, Any>() extra["testkey"] = "testvalue" message.extraData = extra viewModel.onSendMessage(message, callback) //ChannelViewModel } }) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#28?email_source=notifications&email_token=AACAZQLQPOOVOUVYRZWAG7TQMWACJA5CNFSM4ITFX7L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAHBREA#issuecomment-537794704>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACAZQPZOEJOT3DGOH7AVQLQMWACJANCNFSM4ITFX7LQ> .

[luknow93]

Awesome, can't wait 🤓

[adrian09h]

master supports it now.

If message has extradata, all key&values of extradata are set on SendMessageRequest by MessageGsonAdapter.

public class MessageGsonAdapter extends TypeAdapter<Message> {
    private static final String TAG = MessageGsonAdapter.class.getSimpleName();

    @Override
    public void write(JsonWriter writer, Message message) throws IOException {
        HashMap<String, Object> data = new HashMap<>();

        if (message.getExtraData() != null && !message.getExtraData().isEmpty())
            for (Map.Entry<String, Object> set : message.getExtraData().entrySet())
                data.put(set.getKey(), set.getValue());
...

Extradata of Channel, User and Attachment same as Message.

[luknow93]

Hey!
just tried master and can confirm that the data is coming down in Attachment.extraData and Message.extraData.

One question tho, at what point can I edit the extraData of the message thats about to be send from my end(I need to attach some extras for every message I send)?
Previously it was possible through MessageInputView.SendMessageListener but now it's only returning the send result/error. I tried to walk through the whole send sequence, from hitting the button to building request, but couldn't find a place I could plug myself in.

[tschellenbach]

At the moment you need your own custom message input component, going to make this easy to change this in the future though

[luknow93]

Hm, I really hoped to avoid that at this point, especially that nothing important can be extended from yours and we need to battle test the whole GetStream before the end of October when Layer goes down :/

Any chance, even temporarily, you could simply add one method to SendMessageListener

public interface SendMessageListener {
        void onBeforeSendMessage(Message message); // <--- new callback
        void onSendMessageSuccess(Message message);
        void onSendMessageError(String errMsg);
    }

And then call it right before the Message is handed over to viewModel?

private void onSendMessage(String input, boolean isEdit) {
        binding.ivSend.setEnabled(false);

        if (isEdit) {
            getEditMessage().setText(input);
            getEditMessage().setAttachments(messageInputClient.getSelectedAttachments());
            viewModel.getChannel().updateMessage(getEditMessage(),  new MessageCallback() {
                @Override
                public void onSuccess(MessageResponse response) {
                    initSendMessage();
                    binding.ivSend.setEnabled(true);
                    clearFocus();
                }

                @Override
                public void onError(String errMsg, int errCode) {
                    initSendMessage();
                    binding.ivSend.setEnabled(true);
                    clearFocus();
                }
            });
        } else {
            Message m = new Message();
            m.setStatus(null);
            m.setText(input);
            m.setAttachments(messageInputClient.getSelectedAttachments());
                                                            //<-- new line
            if (sendMessageListener != null)                //<-- new line    
                sendMessageListener.onBeforeSendMessage(m); //<-- new line
                                                            //<-- new line
            viewModel.sendMessage(m, new MessageCallback() {
                @Override
                public void onSuccess(MessageResponse response) {
                    binding.ivSend.setEnabled(true);
                    initSendMessage();
                    if (sendMessageListener != null)
                        sendMessageListener.onSendMessageSuccess(response.getMessage());
                }

                @Override
                public void onError(String errMsg, int errCode) {
                    initSendMessage();
                    binding.ivSend.setEnabled(true);
                    if (sendMessageListener != null) {
                        sendMessageListener.onSendMessageError(errMsg);
                    } else {
                        Utils.showMessage(getContext(), errMsg);
                    }
                }
            });
        }
    }

If not(or maybe I'm missing something else?) then I'm just gonna fork the repo for now and tweak it myself.

[luknow93]

You guys are the BEST!! 👏👏👏