Comments (11)
yes, I started to dive in the NNBD issue, but I'll focus on this one first !
from sentry-dart.
This comment: #103 (comment)
Today what we have is a step forward but still we're not there.
sentry.dart.browser
makes when Dart is compiled to JS and runs on the browser. That is not the case for Flutter Web. So for Flutter Web we would still want to have sentry.dart.flutter
. On Flutter we can add a tag to identify if it's ios/android/web/windows
etc. Maybe flutter.platform=...
.
from sentry-dart.
Here we vary the client based on platform. That'll work for sentry.dart.browser
, that could be set on the SentryBrowserClient class and sentry.dart
on the SentryIoClient.
For Flutter we can pass the sdk.name through init
when when the sentry_flutter
package calls init in the sentry
package.
from sentry-dart.
cool, so we could start with this for sentry.dart.browser
and sentry.dart
but tackling sentry.dart.flutter
in the next sprint as its focused on flutter, thanks!
from sentry-dart.
right now it's sentry.dart
for flutter, dart and web.
ideally we'd have sentry.dart
, sentry.dart.flutter
, sentry.dart.browser
.
right now it's controlled by https://github.com/getsentry/sentry-dart/blob/main/dart/lib/src/version.dart
from sentry-dart.
on Android/Java we do it thru the build system using Gradle plugins and code generation: https://github.com/getsentry/sentry-java/blob/main/sentry/build.gradle.kts#L75-L76
let's timebox this and do at a later point if it's not easy/fast
from sentry-dart.
fixed in #96
from sentry-dart.
fixed in #96
wrong PR? I don't see any commits or review about it (Change SDK Name based on the platform) on #96 ?
from sentry-dart.
@marandaneto thanks, and sorry, I need more coffee this morning :s
from sentry-dart.
@marandaneto thanks, and sorry, I need more coffee this morning :s
no worries, are you working on that then?
from sentry-dart.
from sentry-dart.
Related Issues (20)
- Cannot capture user feedback HOT 1
- setUser `data` object values not visible in issue context HOT 4
- ANR on NativeModuleListLoader.nativeLoadModuleList HOT 3
- Error when building using sentry_flutter 8.2.0 HOT 1
- Zone mismatch error on Flutter web with Flutter v3.22.0 HOT 1
- SentryExceptionFactory.getSentryException HOT 8
- Unsupported operation: Platform._operatingSystem when compiling to wasm HOT 1
- View Hierarchy: Option to disable reporting of identifiers/tags
- Allow already initialized Sentry instances to be used in other packages HOT 6
- Issue running on iOS simulator on MacOS Sequoia HOT 13
- `setExtra` while configuring scope throw ClassCastException HOT 2
- wasm HOT 2
- pendingTimer when testing with SentryNavigatorObserver on sentry_flutter 8.2.0 HOT 2
- Add rewrite frames integration HOT 4
- can not report fatal error HOT 17
- Deprecate and remove user segment
- Add an API that pauses/resumes reporting app hangs
- (docs): update features page for dart & flutter
- Semantic Issue (Xcode): Cannot find protocol declaration for 'SentryMXManagerDelegate' HOT 7
- SentryNavigationObserver is not catching tab route changes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentry-dart.