Comments (8)
SDK developers are not supposed to set this attribute so I would not like to document this in SDK dev docs, but the code comments do need some love. We only have this:
After server-side processing, the old SDK-provided stacktrace is backend up in this attribute
from relay.
@untitaker We can take a pass through both sentry-docs (again 😄)and the protocol, to explicitly mark all fields as required, recommended or optional. Additionally, we can also qualify which attributes are for internal use only.
I'm thinking at least along the lines of how we documented outcomes (here it declares where an outcome is emitted):
relay/relay-server/src/actors/outcome.rs
Lines 80 to 82 in 1f0d5f8
from relay.
SDK developers are not supposed to set this attribute
I didn't know. For whatever reason, this field is defined and exported (public) in the Go SDK causing unnecessary confusion.
from relay.
Do you want to document culprit, title and Metadata as well? I considered them out of scope in principle, but in any case i see them in the same bucket as raw_stacktrace
from relay.
The rule in the past was that we do not document internal attributes in external docs. Culprit, for example, was explicitly removed because it is no longer considered public API.
I would propose we mark all fields in Relay, and we ensure that this is also reflected in docs for all attributes that are not internal.
from relay.
I would propose to put all internal fields in an internal
object, an internal object can appear at any level.
Anything under a field internal
is ... internal and shouldn't be messed with by any SDK, similar to internal
packages in Go ( this should please Rodolfo).
from relay.
Putting them in objects would be challenging, but we can have an annotation that is parsed and rendered in documentation, up to the point that we hide it in some places.
from relay.
Sure documenting it would help and would be easier that adding another sub-object any time you need some "private" fields. I still believe that serializing internal fields in an internal
sub object would make it universally clear (whether you are looking at the structure definition, the structure usage, the serialized object or the documentation).
from relay.
Related Issues (20)
- Accept DSC as item header
- [Flaky CI]: always_spools
- Add support for the `base64` format HOT 2
- project_cache: failed to start buffer service - (code: 14) unable to open database file HOT 4
- Emit Negative Outcomes: Denied Metrics
- Configure Relay aggregator for `custom` to 60s granularity HOT 1
- "relay_server::services::store: StoreService received unexpected item type" Error from sentry-self-hosted-relay-1 container after upgrade from 23.8.0 to 24.4.1 HOT 4
- Cloudflare IP visible in Sentry for NextJs tunnel instead of real user IP HOT 1
- Release ARM Binaries HOT 1
- Unprotected ForwardedFor extraction HOT 3
- Update Thread distribution between Relay runtimes
- Propagate `received_at` field of `BucketMetadata` to Kafka and consume it
- Relay should not fail on invalid DSN in the header HOT 1
- Emit negative outcomes when metrics are dropped because of invalid namespace HOT 1
- [EPIC] Span ingestion Q2
- Accept binary Otel spans in envelope
- Remove generators from consumers in integration tests
- Call inbound filter logic in in `span::process`.
- Implement `event.` getters for spans to have a compatibility mode for generic inbound filters. This is a best-effort task, probably only a handful of fields make sense (e.g. release, environment, ...).
- ERROR relay_server::services::project HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from relay.