Coder Social home page Coder Social logo

Comments (8)

untitaker avatar untitaker commented on June 18, 2024 1

SDK developers are not supposed to set this attribute so I would not like to document this in SDK dev docs, but the code comments do need some love. We only have this:

/// Optional unprocessed stack trace.

After server-side processing, the old SDK-provided stacktrace is backend up in this attribute

from relay.

jan-auer avatar jan-auer commented on June 18, 2024 1

@untitaker We can take a pass through both sentry-docs (again 😄)and the protocol, to explicitly mark all fields as required, recommended or optional. Additionally, we can also qualify which attributes are for internal use only.

I'm thinking at least along the lines of how we documented outcomes (here it declares where an outcome is emitted):

/// [Post Processing] An event with the same id has already been processed for this project.
/// Sentry does not allow duplicate events and only stores the first one.
Duplicate,

from relay.

rhcarvalho avatar rhcarvalho commented on June 18, 2024

SDK developers are not supposed to set this attribute

I didn't know. For whatever reason, this field is defined and exported (public) in the Go SDK causing unnecessary confusion.

from relay.

untitaker avatar untitaker commented on June 18, 2024

Do you want to document culprit, title and Metadata as well? I considered them out of scope in principle, but in any case i see them in the same bucket as raw_stacktrace

from relay.

jan-auer avatar jan-auer commented on June 18, 2024

The rule in the past was that we do not document internal attributes in external docs. Culprit, for example, was explicitly removed because it is no longer considered public API.

I would propose we mark all fields in Relay, and we ensure that this is also reflected in docs for all attributes that are not internal.

from relay.

RaduW avatar RaduW commented on June 18, 2024

I would propose to put all internal fields in an internal object, an internal object can appear at any level.
Anything under a field internal is ... internal and shouldn't be messed with by any SDK, similar to internal
packages in Go ( this should please Rodolfo).

from relay.

jan-auer avatar jan-auer commented on June 18, 2024

Putting them in objects would be challenging, but we can have an annotation that is parsed and rendered in documentation, up to the point that we hide it in some places.

from relay.

RaduW avatar RaduW commented on June 18, 2024

Sure documenting it would help and would be easier that adding another sub-object any time you need some "private" fields. I still believe that serializing internal fields in an internal sub object would make it universally clear (whether you are looking at the structure definition, the structure usage, the serialized object or the documentation).

from relay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.