Coder Social home page Coder Social logo

Revision option for prepare about craft HOT 4 CLOSED

getsentry avatar getsentry commented on May 18, 2024
Revision option for prepare

from craft.

Comments (4)

tonyo avatar tonyo commented on May 18, 2024

What would be the semantics of prepare with rev provided?
Do you want to create the release branch based on that revision?

from craft.

Jean85 avatar Jean85 commented on May 18, 2024

Yes, exactly. I needed that today here: getsentry/sentry-symfony#283
Master was already ahead (3.3.x, new minor version) and I needed to release a patch (3.2.1) using
8a176d7 as a revision, before merging master in that branch.

craft release --rev is able to do that, but I do not have enough permission, so @HazAT had to do that for me, without my help and review beforehand with craft prepare.

from craft.

tonyo avatar tonyo commented on May 18, 2024

Just to clarify: as far as I understand, the agreement here was that release would be run by @HazAT anyway, so adding new features to prepare will not really fix it.

Regarding the feature itself, generally I agree that it'd make sense to add it.
To agree on the semantics, craft prepare --rev REV VERSION will do the following:

  • Checkout REV
  • Check that the changelog for the new version (VERSION) is there (if the changelog check is configured)
  • Create a new release branch
  • Run pre-release command (which is user-configured, it usually bumps the version in some files, and you can run some additional checks there) and commit the changes
  • Push the release branch

Does it sound good?

from craft.

Jean85 avatar Jean85 commented on May 18, 2024

Yes, absolutely!

from craft.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.