Comments (4)
What would be the semantics of prepare
with rev
provided?
Do you want to create the release branch based on that revision?
from craft.
Yes, exactly. I needed that today here: getsentry/sentry-symfony#283
Master was already ahead (3.3.x, new minor version) and I needed to release a patch (3.2.1) using
8a176d7 as a revision, before merging master in that branch.
craft release --rev
is able to do that, but I do not have enough permission, so @HazAT had to do that for me, without my help and review beforehand with craft prepare
.
from craft.
Just to clarify: as far as I understand, the agreement here was that release
would be run by @HazAT anyway, so adding new features to prepare
will not really fix it.
Regarding the feature itself, generally I agree that it'd make sense to add it.
To agree on the semantics, craft prepare --rev REV VERSION
will do the following:
- Checkout REV
- Check that the changelog for the new version (VERSION) is there (if the changelog check is configured)
- Create a new release branch
- Run pre-release command (which is user-configured, it usually bumps the version in some files, and you can run some additional checks there) and commit the changes
- Push the release branch
Does it sound good?
from craft.
Yes, absolutely!
from craft.
Related Issues (20)
- Release drafts persist after failed publish attempt
- Prevent releasing beta versions and newer major overrides for Brew releases
- Add AWS Lambda Layer `Description`
- Resume publishing a Rust crates workspace
- Changelog breaks on first release HOT 2
- target(npm): Cleanup "next" tag when releasing newer version
- Add Release Date when adding version to changelog
- Switch maven target from using maven to gradle as build system HOT 2
- Craft fails the release-registry target if version already exists HOT 3
- Add target for Hex/Elixir
- Rename UPM target to a more generic name HOT 2
- Releasing never-before-released project fails HOT 2
- Add new `## Unreleased` section to CHANGELOG.md after replacing it with the just-released tag HOT 8
- Craft should provide info of artifacts found and filtered
- Do not rely on hacky solution for checksum validation
- Verify whether Sentry is correctly set for Craft and improve its usage
- Add more target-specific tests
- Release failed merging back into main but worked HOT 4
- Use https://keepachangelog.com format HOT 11
- Make a release in a Sentry instance when deploying a release HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from craft.