eosjs and eosjs2 should be listed as peer dependencies about scatter-js

[nsjames]

You mean them having to pull in their own versions of eosjs/2?

Yes, exactly! There are multiple benefits. The main benefit is that, If user want to support using eosjs2 without scatter (while also reserve the usage of using eosjs2 with scatter), then user won't import another eosjs2 instance, which means smaller bundle file size. If you have some requirements for the version of user's eosjs2, then it should be listed in the peer dependency version. See https://nodejs.org/en/blog/npm/peer-dependencies/

[nsjames]

ScatterJS doesn't come with eosjs or eosjs2. It's up to the developer to provide the version of those libraries they are using so that they aren't locked into certain versions because that's what we're using.

But it does come with one in plugins 😅 https://github.com/GetScatter/scatter-js/blob/master/packages/plugin-eosjs2/package.json#L7

[nsjames]

Errr, not really. It's listed in the dependencies but never pulled into the packed or built libraries so it doesn't exist inside of the files you'd be importing. I removed it from my local ( and on the eosjs on too which seemed to be there as well ) and have pushed it to the repo, but it can't be pushed to npm or the cdn because no changes happened on the exports so no versioning can occur. Next time I push changes it'll update the package json.

9b56a8f

Oh, got it. Thanks a lot!