Coder Social home page Coder Social logo

Comments (5)

aguynamedben avatar aguynamedben commented on June 15, 2024 1

Also, thanks again for providing this library, it helped us solve a hard problem.

In other parts of our app we're now playing with similar ideas around wrapping Promises as special-case Observables that return a single value. Async world is crazy!

from caf.

aguynamedben avatar aguynamedben commented on June 15, 2024

I think this is doing the trick, I'm not sure if there's a more direct way to just pass something to Axios' cancelToken, though.

The idea is:

  • Listen for CAF to tell us about cancelation
  • Forward the cancelation to Axios in the way that Axios documents
  static sync = CAF(function *sync(signal, syncRequest) {
    // Axios cancellation
    const CancelToken = axios.CancelToken;
    const source = CancelToken.source();
    signal.pr.catch((reason) => {
      log.warn(`canceling any outstanding axios requests, reason: ${reason}`);
      source.cancel();
    });

    const response1 = yield axios.get(`/members/${id}`, {
      params: {
        foo: 'bar',
      },
      cancelToken: source.token,
    });

    const response2 = yield axios.get(`/members/${id}`, {
      params: {
        baz: 'bang',
      },
      cancelToken: source.token,
    });

from caf.

getify avatar getify commented on June 15, 2024

Perhaps try:

yield axios.get(.. , {
   // ..
   cancelToken: new axios.CancelToken(cancel => signal.pr.catch(cancel))
})

from caf.

getify avatar getify commented on June 15, 2024

Closing for now, hopefully that suggestion worked.

from caf.

aguynamedben avatar aguynamedben commented on June 15, 2024

Hey, thank you for the reply, and sorry for the delay in reporting back. Here's what I'm doing now, but I will try your method when I get a chance.

    // Forward CAF cancellation to Axios so we can abort a sync mid-request. We
    // don't need to do this in every DataSource, it's an optimization, but
    // maybe there's a way we can generalize it in the main DataSource class one
    // day.
    // https://github.com/getify/CAF/issues/16#issuecomment-640120307
    const CancelToken = axios.CancelToken;
    const source = CancelToken.source();
    signal.pr.catch((reason) => {
      log.debug(`canceling any outstanding axios requests, reason: ${reason}`);
      source.cancel();
    });

    // Get boards ids for member and orgs - /members/{id}
    log.debug(`getting board - /members/${account.upstreamId}`);
    const boardsResponse = yield client.get(`/members/${account.upstreamId}`, {
      params: {
        fields: 'idBoards',
        organizations: 'all',
        organization_fields: 'idBoards',
      },
      cancelToken: source.token,
    });

from caf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.