Problem with headersForQuery about brick

[polRk]

It's little fix.

• Save old headers;
• Add new headers;
• Send request
• Wait response
• Remove new headers
• Return response

  Future<http.StreamedResponse> send(http.BaseRequest request) async {
    final token = await _tokenRepository.getIdToken();

    request.headers['Authorization'] = 'Bearer $token';
    
    final response = await _inner.send(request);
    request.headers.remove('Authorization');
    
    return response;
  }

[polRk]

But if you want to use providerArgs with custom httpClient, you should add

final defaultHeaders = <String, String>{
  'Content-Type': 'application/json; charset=utf-8'
};

final providerArgs = <String, dynamic>{
  'request': 'PUT',
  ...defaultHeaders,
};

...

restProvider: RestProvider(client: client)..defaultHeaders = defaultHeaders,

[tshedor]

Thanks @polRk for helping out with this one!

@pkozlovskiy Are you subclassing RequestSqliteCache? It sounds like you might be if you're mutating the headers on subsequent retries.

In this use case, I would instead recommend implements over extends so that you're not storing the headers or making SQLite queries based on the headers.

I hadn't anticipated this sort of usage, so my other suggestion is to open a PR and make _findRequestInDatabase a @visibleForOverriding method. That way, you'll be able to ignore the headers column (since these change) in subsequent lookups and you'll be able to extends RequestSqliteCache without rewriting a lot of the functionality. I also think making headersForQuery a method that's @visibleForOverriding instead of @protected would be useful.

[tshedor]

@pkozlovskiy With #122 merged I'm going to close, please reopen if you're still having trouble