Design for CRS extension about geoxarray

[djhoese]

@atedstone FYI #13

[djhoese]

A couple questions/clarifications if you could:

2. Is there any reason that geo.crs has to be set or should crs_from_cf allow users to provide the CF grid mapping information to create the CRS with the default (no arguments) being to look at the current Dataset/DataArray for expected attributes?

3. This could only be done for Datasets right?

My understanding was that geoxarray would be providing utilities for creating the crs coordinate and adding additional "standard" attributes (CF, etc) from an existing crs coordinate. Let me know if this isn't what you were thinking.

[snowman2]

Is there any reason that geo.crs has to be set or should crs_from_cf allow users to provide the CF grid mapping information to create the CRS with the default (no arguments) being to look at the current Dataset/DataArray for expected attributes?

Ideally, it would be best for the CRS to be pulled from the current Dataset/DataArray expected attributes. However, there are so many different ways that this data is stored that it is likely going to fail if it is on a non-standard location or format. With this line of thinking, it would be nice to have multiple methods for setting the CRS as a backup. For example, if you already have a pyproj.CRS or rasterio.CRS generated using an alternate method, it would be nice to be able to:

geo.crs = CRS("epsg:4326")

I guess you could do:

geo.crs_from_cf(crs_wkt=CRS("epsg:4326").to_wkt())

But, it is not as clean IMO.

This could only be done for Datasets right?

This can work for both data arrays and datasets. If it is a data array, then it is much simpler as you only have one location to search for the CRS. Whereas if it is a dataset, then some logic needs to be added to determine which CRS is used by which variable if there are more then one (or just assume that there is only one CRS for the entire dataset).

My understanding was that geoxarray would be providing utilities for creating the crs coordinate and adding additional "standard" attributes (CF, etc) from an existing crs coordinate. Let me know if this isn't what you were thinking.

Yes, this is what I am thinking is the end goal. But, until it is ready in geoxarray, I was thinking about adding it in to rioxarray as a temporary addition that can be replaced at a later date.

[djhoese]

So is data_arr.geo.crs = CRS(...) kind of a magic "take this CRS information and add it to my Dataarray whether it be a dictionary (of CF attributes), a rasterio CRS object, or a pyproj CRS object, or something else?

Looking at the spatial_ref stuff I think I get it a little better now. It is being added as a coordinate variable and not as another variable in a Dataset.

[snowman2]

So is data_arr.geo.crs = CRS(...) kind of a magic "take this CRS information and add it to my Dataarray whether it be a dictionary (of CF attributes), a rasterio CRS object, or a pyproj CRS object, or something else?

That is the general idea. I am not sure about the CF dict as there can also be PROJ dicts. So, you would need a way to differentiate. Maybe look for proj or init for PROJ string versus grid_mapping_name, crs_wkt or spatial_ref for CF dict.

[djhoese]

I'd say that wouldn't be a bad idea if the property is already magic-ish.

[snowman2]

Okay, sounds good to me 👍

[atedstone]

Hi. I'd been poised a couple of days ago to generalise some of my existing code from a couple of years ago for writing CF-compliant netcdfs using xarray, but some searching revealed this project. I can give some time to helping with getting and setting CRS info on xarray Datasets, especially in creating functionality to write CF-compliant netCDFs. Before I start anything though, is there any local development of the CRS extension happening at the moment that hasn't made it to Github?

[djhoese]

Yes! I was just about to push the changes even though I wasn't happy with everything. I'd also check out @snowman2's progress on rioxarray.

[djhoese]

Closing this as the initial support in #26 is merged and mimics rioxarray's support. That is, .geo.crs gives you a pyproj CRS object. .geo.write_crs writes a CF-compatible grid_mapping variable to the .coords of the current xarray object. Due to difficulties persisting information in an xarray accessor there is no way to provide the geoxarray accessor CRS information without persisting it with .geo.write_crs. Put another way, it is too easily to accidentally lose the temporary/internal CRS information if it isn't persisted in the xarray object itself.