Feature Attribute Form - Identify tool - Edit mode about mapstore2-georchestra

[tdipisa]

@offtherailz @vlt1
we need a simple mockup for this before staring the development, few buttons are needed here but I would like a mockup anyway.

[vlt1]

@offtherailz it seems that identify plugin works by doing WMS GetFeatureInfo request, whereas Attribute Table works through WFS. The question is how to connect two together for the purposes of editing features(in case of JSON output). I can see that WMS request contains BBOX that I'm guessing it uses to filter out the features. It looks like WFS can filter by BBOX. Can I use the BBOX from WFS request and supply it to Attribute Table filter object, then wait for the response and select the requested feature to edit from the list? Would that work? Are there other ways to do it? What do you think? Also it looks like the floating identify tool is not ready yet(there is a pending pr for it). Should it be ignored for now?

[offtherailz]

Some clarifications

• Only the layers that can can open attribute table can have the edit link in feature info (so the search --> type: wfs entry). This means that WMS service have a corresponding WFS service layer with the same name do browse vector data
• The pending PR should be merged in 1/2 days, so you can add the button also from that entry point.
• WFS as various ways of filtering. bbox is not suggested because it is mutually esclusive with other kind of filtering (Filter/CQL_FILTER).

I suggest, when the user clicks on edit button:

• to open the attribute table
• switch to edit mode
• filtered by point clicked using the current filtering system with a geometric intersection with the point clicked
  • note: I suggest to use the QUERY:UPDATE_FILTER, the same action used by quick filter entries. This quick filters should be automatically reset on exit from feature grid. I'm not sure it is supports also for geometric attributes, but we can add support to it.

This should filter the feature info (and also the map, if the map sync is enabled) with the original selection.
At the end you can close again the feature grid (and reset the filter)

It could be useful if this quick point intersection filter is somehow highlighted in the feature grid.
Here I ask to @tdipisa :
It should be great if the quick filter is used also in normal context. Please let me know

[vlt1]

I'm not sure it is supports also for geometric attributes, but we can add support to it.

UPDATE_FILTER works with filterFields. If I understand correctly for geometric filtering there is a spatialField prop in filter object that is handled separately.

filtered by point clicked using the current filtering system with a geometric intersection with the point clicked

Identify gets all features within a specific region(I assume it's the bbox), so just geometric intersection with the point clicked would not suffice, as the result would differ from Identify and we won't be able to select the needed feature. Maybe we could just use a polygon with bbox coordinates intersection, it seems like the results that we would get would be a superset of what Identify gets, so we could select the needed feature. Am I correct in this assumption?

Also there is a pending pr for an ability to select features by clicking on a map when in edit mode of Attribute Table. It modifies the edit mode flow and utilizes filters. The implementation provided there may be not to your satisfaction and should be changed. The point I'm making is that changes to filtering probably should be first introduced in that pr first. In any case I think it should be merged before we proceed with this one. With that being said please review it as soon as possible.

[tdipisa]

@offtherailz I agree with you, but please consider also the implementationof #48 that has some points of contact regaring the point selection.

[tdipisa]

@vlt1 Moving it back to ready after testing.

If I open the Attribute table from TOC with the Identify panel opened, the marker remains in the map.