Comments (8)
The admin is being turned on conditionally, depending on the pygeoapi config. However, the import of
jsonpatch
happens regardless.
@ricardogsilva indeed that does not seem correct.
I am in favour of the second option (admin as optional). I can think of use cases where people don't need an admin UI and just want a simple, lightweight, API.
from pygeoapi.
Should we mention it on the admin page that to run is successfully, user should also execute pip install -r requirements-admin.txt
from pygeoapi.
@krishnaglodha well spotted! 👍🏽 Do you want to do a PR to add that line to the docs?
pygeoapi/docs/source/installation.rst
Line 29 in d66e790
+ pip3 install -r requirements-admin.txt
from pygeoapi.
from pygeoapi.
I propose to have this on the doc page of admin, because we are not sure that everyone will be using admin function, thus, let people know about this only on admin doc page ?
from pygeoapi.
If that would be the case, then the packages specified on requirements-admin.txt
ought to be optional, which does not seem to be the case currently, which I guess is a bug?
The admin is being turned on conditionally, depending on the pygeoapi config. However, the import of jsonpatch
happens regardless.
from pygeoapi.
I guess a decision needs to be taken on whether:
-
The admin is part of the default pygeoapi experience, in which case I guess there is no need for a separate
requirements-admin.txt
file and the admin dependencies become regular pygeoapi dependencies - no need to modify the installation docs in this case. -
The admin is indeed optional, in which case the docs need to be adjusted and the code needs to include some guards that ensure the admin dependencies are not imported unconditionally
@tomkralidis @webb-ben , what would be your thoughts on this?
from pygeoapi.
PR in #1485
from pygeoapi.
Related Issues (20)
- Translate static texts HOT 1
- fix CI failure on SensorThingsAPI
- Error unable to find 'properties' key with ElasticSearch provider HOT 1
- 'API' object has no attribute 'get_collection_item' HOT 3
- Missing Access-Control-Expose-Headers: Location HOT 6
- add support for item schema string format HOT 4
- Unsupported Column Types using PostgreSQL provider. HOT 2
- items collection link should point to collection
- Wrong extent/bbox axis-ordering for some collections in Docker pygeoapi config
- html display does not show prev-next page (anymore) HOT 4
- add traslation markers (II)
- Use osgeo weblate for translations?
- Request parsing discards unknown output formats
- providers should be allowed to modify response headers
- Test for TinyDBManager report successful while not performing any assert HOT 1
- Unconsistent return response object for delete_job() method in pygeoapi.api.processes HOT 1
- add TinyDB feature provider
- add CITE setup for Tiles HOT 2
- EDR HTML View should offer more information HOT 1
- promote process manager concept to the application level
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pygeoapi.