Coder Social home page Coder Social logo

Add Google basemaps about xyzservices HOT 10 CLOSED

giswqs avatar giswqs commented on June 6, 2024
Add Google basemaps

from xyzservices.

Comments (10)

martinfleis avatar martinfleis commented on June 6, 2024 2

@giswqs With #65 there is a convenient way of getting Google's base maps as a TileProvider, so I suggest closing this issue and not including them directly in our JSON. Would it be okay with you? With your opengeos/leafmap#92 you can pass Google Hybrid to leafmap as

basemap = xyzservices.TileProvider.from_qms("Google Satellite Hybrid")
m = leafmap.Map()
m.add_basemap(basemap)

from xyzservices.

martinfleis avatar martinfleis commented on June 6, 2024

That would be a welcome contribution! Would you like to make a PR? I would add them as a single Bunch.

New providers should be added to https://github.com/geopandas/xyzservices/blob/main/provider_sources/xyzservices-providers.json. See the contributing docs https://xyzservices.readthedocs.io/en/latest/contributing.html#providers

from xyzservices.

giswqs avatar giswqs commented on June 6, 2024

I will work on it and submit a PR later today.

from xyzservices.

martinfleis avatar martinfleis commented on June 6, 2024

Actually, can you ensure we can legally use those? I am not entirely sure about that based on https://developers.google.com/maps/faq#tos_tiles.

from xyzservices.

giswqs avatar giswqs commented on June 6, 2024

This is interesting to know. I didn't realize that. I have been using these map tiles for years through the QGIS QuickMapServices Plugin. I am not sure how this plugin handles the legal issues.

from xyzservices.

martinfleis avatar martinfleis commented on June 6, 2024

It seems that they just don't care.

I was wondering such an obvious source is not already included. See leaflet-extras/leaflet-providers#236, leaflet-extras/leaflet-providers#288, and leaflet-extras/leaflet-providers#22 as a reference.

Strictly speaking, we are not using those tiles, just providing their metadata so we wouldn't violate TOS if we included them. But anyone who would use them from xyzservices would if I understand correctly. A bit of a grey zone here (but I think that leafmap does violate it).

from xyzservices.

giswqs avatar giswqs commented on June 6, 2024

Thanks for linking these references. I agree it is a grey area. I will change leafmap's default basemap to other free tiles rather than Google Maps.

So, do we still want to include their metadata in xyzservices? I can submit a PR if you want. If not, we can close this issue.

from xyzservices.

giswqs avatar giswqs commented on June 6, 2024

I have changed leafmap's default basemap from Google Maps to OpenStreetMap, but I keep the metadata of Google map tiles for users who want to use them at their own risk. If Google comes after me, I will then remove them.
opengeos/leafmap#91

image

from xyzservices.

martinfleis avatar martinfleis commented on June 6, 2024

So, do we still want to include their metadata in xyzservices?

I am really not sure. If we do so, we should add a notice to the docs that users should always check the TOS of the provider (which we maybe should do anyway).

@darribas @jorisvandenbossche any thoughts on this?

from xyzservices.

giswqs avatar giswqs commented on June 6, 2024

Yes, this is a much better solution. Thank you.

from xyzservices.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.