Coder Social home page Coder Social logo

Comments (4)

martinfleis avatar martinfleis commented on June 19, 2024 2

@TomAugspurger We don't depend on it. It is used only in CI. We use the custom numba implementation ported from spatialpandas.

from dask-geopandas.

martinfleis avatar martinfleis commented on June 19, 2024

One more thing to add is to ensure that codecov sees the coverage of numba jitted functions. We'll probably need to run that bit again without that using env variable.

from dask-geopandas.

tastatham avatar tastatham commented on June 19, 2024

Another follow up is to centralise/ generalise several functions that are used by both hilbert_distanceandmorton_distance`.

  • Firstly, the _continuous_to_discrete_coords function is imported from hilbert_distance.py in morton_distance.py - centralise
  • Secondly, the _distances_from_coordinates function is used in both hilbert_distance.py in morton_distance.py but are defined in slightly different ways - generalise

from dask-geopandas.

TomAugspurger avatar TomAugspurger commented on June 19, 2024

I didn't follow this implementation closely, but is the plan to rely on the hilbertcurve package long-term? If so, it needs to be added to the install_requires:

dask-geopandas/setup.py

Lines 6 to 11 in 99fa1a8

install_requires = [
"geopandas",
"dask>=2.18.0,!=2021.05.1",
"distributed>=2.18.0,!=2021.05.1",
"numba",
]
.

from dask-geopandas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.