Coder Social home page Coder Social logo

Comments (14)

ukemi avatar ukemi commented on June 9, 2024 1

Since using the substring is they way I used to search for models, I think curators would want to search in that manner.
I think curators might ask for 2, but I'm not sure that it really saves them time or effort in the long run because they will still look at one model at a time.

from noctua-landing-page.

tmushayahama avatar tmushayahama commented on June 9, 2024

@goodb does the search API current allow search by model id?

from noctua-landing-page.

goodb avatar goodb commented on June 9, 2024

@tmushayahama not right now. We can add it. Want to add an issue to minerva ?

from noctua-landing-page.

tmushayahama avatar tmushayahama commented on June 9, 2024

@goodb have added geneontology/minerva#333

from noctua-landing-page.

tmushayahama avatar tmushayahama commented on June 9, 2024

@ukemi @vanaukenk I will go ahead and put it on dev server. So far it works like any other filters (in combination with other filters and can take multiple model ids)

image

thanks @goodb

from noctua-landing-page.

vanaukenk avatar vanaukenk commented on June 9, 2024

Thanks @tmushayahama !

I tested on dev and it found all of the models I tested with the correct results number.

I have two other thoughts that maybe @ukemi can weigh in on, as well:

  1. Do we think curators will ever want to search with a model id substring, e.g. 5b91dbd100002412 (without the gomodel prefix)?

  2. Do we think curators will ever have a list of model ids that they might want to cut and paste into the search box? Right now it looks like I have to type in one model id at a time, hit return, and then type in the next model id.

from noctua-landing-page.

vanaukenk avatar vanaukenk commented on June 9, 2024

From the 2020-07-29 workbenches call:

  1. Add ability to search using just the model id without the 'gomodel:' prefix.

  2. Strip '?' from the end of a model id entry in case someone cuts and pastes from a noctua URL.

Thx.

from noctua-landing-page.

vanaukenk avatar vanaukenk commented on June 9, 2024

This all looks good except for issue 2 above.
If a curator cuts and pastes the model id from the graph editor URL, there is a question mark at the end that, if included, causes the search to fail.
@tmushayahama - can you double-check the code here to see if it's possible to strip a '?' at the end of the model id?
Thanks.

from noctua-landing-page.

vanaukenk avatar vanaukenk commented on June 9, 2024

Double check with @kltm that all GO-CAM models end in a digit.
If so, @tmushayahama can code the model-id search to look for a regex 'gomodel:string ending in a digit' to find the model id regardless of what curators type into the box.

from noctua-landing-page.

vanaukenk avatar vanaukenk commented on June 9, 2024

Also add a copyable model id to the banner of the Noctua form.

from noctua-landing-page.

kltm avatar kltm commented on June 9, 2024

@vanaukenk As far as I know, there is currently no such requirement for IDs. There may be internal constraints on this in various places, but nothing as far as a formal spec anywhere.

from noctua-landing-page.

kltm avatar kltm commented on June 9, 2024

@vanaukenk In fact, counterexamples currently exist, like 8b595d9e-fc3c-4598-82b5-35c067c4226f.ttl (use of UUID) and pombase_generated_TOR_signaling.ttl.

from noctua-landing-page.

vanaukenk avatar vanaukenk commented on June 9, 2024

Thanks @kltm - that's the info we needed.

@tmushayahama - see @kltm's comment above. Some model ids do end in letters.

from noctua-landing-page.

vanaukenk avatar vanaukenk commented on June 9, 2024

@tmushayahama - I think we are done here. Can you confirm from your POV?

from noctua-landing-page.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.