Coder Social home page Coder Social logo

Comments (2)

xiorcal avatar xiorcal commented on June 21, 2024

i'm making a PR

from beeep.

Equim-chan avatar Equim-chan commented on June 21, 2024

We can't assume the client is always running Windows in English.

On my platform, cmd ver prints

Microsoft Windows [版本 10.0.16299.192]
(c) 2017 Microsoft Corporation。保留所有权利。
...
>cmd ver < NUL | xxd
00000000: 4d69 6372 6f73 6f66 7420 5769 6e64 6f77  Microsoft Window
00000010: 7320 5bb0 e6b1 be20 3130 2e30 2e31 3632  s [.... 10.0.162
00000020: 3939 2e31 3932 5d0d 0a28 6329 2032 3031  99.192]..(c) 201
00000030: 3720 4d69 6372 6f73 6f66 7420 436f 7270  7 Microsoft Corp
00000040: 6f72 6174 696f 6ea1 a3b1 a3c1 f4cb f9d3  oration.........
...

The best fix should be querying registry directly instead of using this trick. I'll try to make a PR soon.

from beeep.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.