Comments (3)
LGTM to produce by default the 3 types of curves. However, I don’t like the way the new parameter was introduced, it does not follow the OQ job.ini standards.
aggregate_loss_curves_type = ,_oep ,_aep
-
The comma is part of the parameter instead of the field separator (super confusing). Right now the separator is the space.
-
If the user wants only EP curves, then the parameter should be set to
aggregate_loss_curves_type =
. It is ambiguous, but it works with the current implementation. -
The user can not get only OEP or AEP curves. if the parameter is set to `aggregate_loss_curves_type = ,_aep , the output includes EP and AEP. Any reason why we need to produce EP by default?
My recommendation is to implement the job.ini parameter as initially suggested
aggregate_loss_curves_type = ep, oep, aep
Where the comma is used to separate the fields. Internally, OQ can have a dictionary to name the functions as required:
{'ep':'', 'oep':'_oep', 'aep':'_aep'}
from oq-engine.
As requested by @CatalinaYepes, I am listing here the deviations and missing details in the current implementation, with respect to the above specifications:
- the new ini parameter is called
aggregate_loss_curves_types
and its value is,_oep,_aep
by default, meaning thatloss
,loss_aep
andloss_oep
will be computed, unless otherwise specified. It is a fast operation, so it's worth computing everything by default. The reason of the seemingly strange format of the parameter is because it is convenient for the sake of the implementation of this feature; - in order to keep consistency with the past, the field that was called
loss
before will not be renamed intoloss_ep
; - consequences other than
loss
are still unchanged - also reinsurance-related functionalities are not implemented yet
from oq-engine.
The points discussed above have been addressed, so now the format for the aggregate_loss_curves_types parameter is as suggested, the EP curves are optional and also reinsurance curves are computed.
Please @CatalinaYepes, can you check if everything is in place or if you see anything missing?
from oq-engine.
Related Issues (20)
- See if we can speedup postclassical in case of tiling HOT 1
- Station data observed values are retained in GMF values in calc datastore.
- Anaconda, Python=3.11.8 Openquake 3.19 Installation Error HOT 1
- Adding new CAV and AI models HOT 3
- multifaultsource sanity check breaks fault section prefix HOT 2
- Should we replace round with numpy.round? HOT 1
- Check invalid branchIDs
- get_convex_hull failing when getting polygons of some mosaic sources
- AAL Statistics output for classical_risk/case_2 not exportable
- NGAEastUSGSGMPE not working outside of unit tests HOT 3
- Fixing warnings in the documentation
- when a required site parameter is not provided, OQ is running full calculation but giving NAN results HOT 2
- Raise error for missing `residents` at the beginning of the calculation
- Stations still appear to be plotted in Avg GMF
- Implementation of post-loss amplification (PLA) HOT 3
- Document `oq show delta_loss`
- Add check in job.ini for scenario calculations
- Investigations for conditioned scenarios (needed for the Aristotle project)
- individual_rlzs is not honored with --hc HOT 1
- Add an early check for mixed sources
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oq-engine.