Comments (12)
I hate this bot. The issue is not fixed, it's being worked on #177.
from ansible-role-gitlab.
Submitting a PR for consideration shortly ...
from ansible-role-gitlab.
Experiencing the same issue.
The quoting breaks the parsing of the gitlab.rb
file.
PR #177 contains a fix.
from ansible-role-gitlab.
This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark issues as stale.
from ansible-role-gitlab.
This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.
from ansible-role-gitlab.
I agree with @JulienPalard. This issue causes an invalid configuation file, breaking Gitlab reconfiguration and updates without manual intervention. Which is exactly a use case one would use Ansible for: the automation.
While I understand closing stale issues, because of bandwidth restrictions, this bot is being overzealous. A fix is available via PR. So you can absolutely use that if you are used to working with git
.
I appreciate @geerlingguy's work a lot, and point out his excellent work to all the people I teach about Ansible, so I hope he can have a look at this issue in person.
Otherwise I hope he reconsiders assigning some form of maintainership to somebody. That person or group doesn't need to have control of the master
branch, some develop or staging branch will do for the community. Keeping @geerlingguy as "benevolent dictator for life" sounds good to me. 😉
from ansible-role-gitlab.
This issue is no longer marked for closure.
from ansible-role-gitlab.
The licenses on my repos are excessively free (MIT is about as 'do what you want' as it gets) to ensure people can easily fork and use the role to do whatever they want.
Note that I maintain these roles for my own use, so if something breaks that affects my use case, I'm often quicker to fix it. If something breaks someone else's workflow, and it doesn't affect mine, I might not get around to it for a while.
I have the stale bot around because for every issue like this one, there are 50 more that are non-helpful support requests that I simply cannot spend my time helping with (especially since about 95% of those never get a response even if I do spend 10 minutes trying to help the lost soul), and I don't want to leave them out to languish forever :( — my time is the most important thing I can control, and unfortunately, even though many people absolutely hate the stale bot, I would not maintain even a tenth of the projects I 'maintain' (for better or worse) without it ;)
from ansible-role-gitlab.
Thanks for taking the time to look at this @geerlingguy . We appreciate it a lot! 😄
The stale bot is not in question and I understand exactly how you feel: time is valuable. I feel the same way.
Having the repos excessively free is something we all thank you for. While I/we could fork it I do stand by my remark to perhaps (re)consider some form of maintainership on your more popular roles (such as this one). Some staging branch would help to keep it centralized instead of creating yet another copy to maintain.
Of course it's your repo, your work, and your decision 👍
Thanks again for your efforts!
from ansible-role-gitlab.
Thanks for the explanation about the bot @geerlingguy, I'll update my opinion on it.
(While I'm off-topic: Thanks for all the things you share, I do appreciate it!)
from ansible-role-gitlab.
With #177 merged this can now be closed.
from ansible-role-gitlab.
Thanks to everyone working on this ♥
from ansible-role-gitlab.
Related Issues (20)
- presets to run GitLab on small instances with 2GB RAM HOT 2
- Data type error in gitlab.rb.j2 template HOT 1
- backup and update HOT 2
- Evaluating 'gitlab_create_self_signed_cert' as a bare variable HOT 2
- Debian 11 - No package matching 'gitlab-ce' is available" HOT 5
- Amazon ami error HOT 1
- GitLab reconfiguration task fails when Ruby deprecation warnings are observed HOT 2
- Installation of GitLab package can timeout HOT 9
- Issue running the GitLab provided install script on a CIS hardened Ubuntu Pro install HOT 3
- Single quotes for `kv.value` can cause errors with certain values HOT 9
- Container Registry should be enabled when gitlab_registry_external_url is referenced HOT 2
- properly way to run role HOT 3
- Support gitlab pages settings in gitlab.rb.j2 template HOT 5
- root password HOT 3
- Error when launching playbook HOT 3
- Internal Gitlab registry failing auth with 401 HOT 1
- letsencrypt configuration flags not working HOT 1
- config error are ignored and ansible always success HOT 1
- Make installation timeout configurable
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ansible-role-gitlab.