Fail after complete DrupalVM upgrade about ansible-role-apache

[fubarhouse]

I'm going to try to diagnose this further before it gets looked at.

[geerlingguy]

@fubarhouse - Thanks for opening the issue—looks like you got it resolved? There's a new configuration variable in example.config.yml, drupalvm_webserver, that needs to be configured. Probably should've put out a little more warning, but it's at least noted in the Drupal VM 2.1.0 release notes.

[fubarhouse]

@geerlingguy I haven't resolved this yet... I will definitely let you know when though - it's very important to me that I get around this one way or another. Also yeah the variables were set as expected, I'll be migrating a lot of websites for launch within the next 36 hours so once I get a bit of down-time I'll be working on this :)

[geerlingguy]

@fubarhouse - Ah, I just noticed:

{% if drupalvm_webserver == 'apache’ %}

It looks like a unicode character snuck in there somewhere. That's not from my code, is it??

The task and the templated fatal error don't match up - that drupalvm_webserver configuration / setting doesn't occur anywhere inside the geerlingguy.apache role.

[fubarhouse]

@geerlingguy Interesting, thanks for the notes!

For the record, the configuration file at the root contains drupalvm_webserver: apache and so that's where the variable is coming from. I noticed the unicoding problem, but I haven't looked into why exactly.

Whatever the case, if the solution is applicable to others it would be worthwhile knowing about it.

[fubarhouse]

@geerlingguy I've managed to get around the problem by replacing

- { role: geerlingguy.apache, when: drupalvm_webserver == 'apache' }
- { role: geerlingguy.nginx, when: drupalvm_webserver == 'nginx' }

with

- { role: geerlingguy.apache, when: drupalvm_webserver == "apache" }
- { role: geerlingguy.nginx, when: drupalvm_webserver == "nginx" }

I'm not sure why in this particular case as the values are plain text without variable references, but it doesn't seem to like string literals.

I don't mind if you use this knowledge or not - all that matters to me is my want to keep things updated as I need or as cool things come out and this exercise has been fun - I don't actually know how many people consistently reprovision their drupalvm systems - the ones using the system I've made are a bit more specialized.

Honestly when coding var == "" should always beat var == '' always unless you use var == "''" to prevent string literals. For example you can't print variables in bash with echo '$var' as it prints $var - and echo "$var" prints the value of $var

This is ultimately your call, but you should know this in case more show up with this problem.