Coder Social home page Coder Social logo

Disabling the navigation emoji, and overriding with functionEmojis calls menu function not callback about discord-paginationembed HOT 7 CLOSED

gazmull avatar gazmull commented on June 15, 2024
Disabling the navigation emoji, and overriding with functionEmojis calls menu function not callback

from discord-paginationembed.

Comments (7)

KyleBoyer avatar KyleBoyer commented on June 15, 2024

@gazmull To think about it, I could work with an onDelete callback too, for both timeout, and emoji delete?

from discord-paginationembed.

gazmull avatar gazmull commented on June 15, 2024

Pushed a fix at patch-1. Let me know if this resolves the issue.

Regarding the additions of further callbacks, I'm thinking of adding an event emitter for such case to avoid severe littering.

from discord-paginationembed.

gazmull avatar gazmull commented on June 15, 2024

This recently added feature also introduced a bug where having empty array will completely disable the navigation emojis. I will be rewriting the whole feature and possibly another interface changes. Feel free to start working on it, I might not have the time due to exams. 🙆‍♂️

ps. patch-1 doesn't fix anything except for the overriding thing.

from discord-paginationembed.

KyleBoyer avatar KyleBoyer commented on June 15, 2024

Sounds good haha! Do you have discord? I wanted to talk to you about code, but some of it is private for competition reasons.

from discord-paginationembed.

KyleBoyer avatar KyleBoyer commented on June 15, 2024

Kyle#9747

from discord-paginationembed.

gazmull avatar gazmull commented on June 15, 2024

Sure thing. Added you with Euni#0011

from discord-paginationembed.

gazmull avatar gazmull commented on June 15, 2024

I'm face palming so hard, it was my proposed fix earlier (just similarly) but can't seem to implement the fix properly. Thanks for the fix.

For future concerns regarding navigation emoji's function still overriding the customised function, please disable the navigation emoji first per logical basis.

Now I can rest peacefully...

from discord-paginationembed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.