Coder Social home page Coder Social logo

Comments (9)

osrf-migration avatar osrf-migration commented on May 27, 2024

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


This happens to me all the time, you forgot the -f before the file path.

I think we have to handle this case better.

from gz-sim.

osrf-migration avatar osrf-migration commented on May 27, 2024

Original comment by Michael Grey (Bitbucket: mxgrey, GitHub: mxgrey).


Thanks, that was the issue! 😅

Is there a particular reason we don't support the world file as a positional argument like the old Gazebo? If we want to commit to no longer supporting that, then we should at least update the help text, which currently says the command signature is:

`ign-gazebo` [options] <world_file>

which implies that you're required to pass a world file at the end as a positional argument (<argument_name> in angle brackets at the end of the command signature usually implies a mandatory positional argument, so we should use brackets [argument_name] for optional arguments).

Additionally, we could print console warnings if users pass in unexpected arguments or neglect to load a world at startup.

from gz-sim.

osrf-migration avatar osrf-migration commented on May 27, 2024

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


+1 to all your suggestions

from gz-sim.

osrf-migration avatar osrf-migration commented on May 27, 2024

Original comment by Michael Grey (Bitbucket: mxgrey, GitHub: mxgrey).


Do you think it would be better to make the world_file argument an optional positional argument to match previous Gazebos, or keep it as a flagged option like it currently is?

from gz-sim.

osrf-migration avatar osrf-migration commented on May 27, 2024

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


I have no preference, but if I remember correctly, @nkoenig had a reason to add a flag initially.

from gz-sim.

osrf-migration avatar osrf-migration commented on May 27, 2024

Original comment by Michael Grey (Bitbucket: mxgrey, GitHub: mxgrey).


I feel like an optional positional argument makes the most sense since it matches typical Unix conventions the closest, but I'll hold off on submitting any changes until we hear from Nate.

from gz-sim.

osrf-migration avatar osrf-migration commented on May 27, 2024

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


  • changed title from "Nothing shows up in the rendering?" to "Don't fail silently when trying to load a world without -f"

from gz-sim.

osrf-migration avatar osrf-migration commented on May 27, 2024

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


See pull request #298

from gz-sim.

osrf-migration avatar osrf-migration commented on May 27, 2024

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


  • changed state from "new" to "resolved"

from gz-sim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.