another mksh/bash difference? about bc

[gavinhoward]

Whoops. That's a bug.

I tried clicking your links, but they complained that I wasn't signed in our didn't have permission.

I presume your obvious fix was to source functions.sh? I'll do that in my repo when I get home. Do you want a tagged release?

[enh-google]

I tried clicking your links, but they complained that I wasn't signed in our didn't have permission.

gah, don't get me started ... the powers that be inflicted a stupid url rewriter on us recently that mean we can't give working urls to anyone. i'd tried to manually fix these, but didn't test them. fixed now (retconned above).

I presume your obvious fix was to source functions.sh?

exactly.

I'll do that in my repo when I get home. Do you want a tagged release?

yes please... our tooling isn't yet clever enough to get us back on to the next tagged release if we switch to a sha, so until we implement that, it's quite a bit more convenient if there's another tag. (especially if i happen to go under a bus :-) )

[gavinhoward]

Fixed in 714782c, which should also preemptively fix any other occurrences of this same bug.

I'm running a basic release process to ensure that the release still builds and tests, but I should have a tag out tomorrow morning (US time).

[enh-google]

I'm running a basic release process to ensure that the release still builds and tests, but I should have a tag out tomorrow morning (US time).

thanks! no hurry...

[gavinhoward]

It's out! Because I haven't been able to get an Android environment going yet, I'm still not sure this will work for you. If it does, though, please close this issue. Otherwise, I'll try something else.

[enh-google]

thanks... testing now: https://android-review.googlesource.com/c/platform/external/bc/+/2436773

[enh-google]

merged! thanks for your help :-)