an idea to implement priority patterns about phpbrowscap

[oschonrock]

sorry, try again on the code:

use phpbrowscap\Browscap;
class PrioritisedBrowscap extends Browscap
{
  /**                                                                                                                                                                                
   *                                                                                                                                                                                 
   */
  protected $priority_patterns = array(
    // this will match the phone ua in front of it if left low down the list                                                                                                         
    'Googlebot\-Mobile', // note that the '-' is escaped in the pattern for some reason                                                                                              
    );
  /**                                                                                                                                                                                
   *                                                                                                                                                                                 
   */
  protected function movePatternToTop($pattern)
  {
    $temp = array($pattern => $this->_patterns[$pattern]);
    unset($this->_patterns[$pattern]);
    $this->_patterns = $temp + $this->_patterns;
  }
  /**                                                                                                                                                                                
   *                                                                                                                                                                                 
   */
  protected function isProrityPattern($pattern)
  {
    foreach ($this->priority_patterns as $priority_pattern)
    {
      if (stripos($pattern, $priority_pattern) !== false)
      {
        return true;
      }
    }
    return false;
  }
  /**                                                                                                                                                                                
   *                                                                                                                                                                                 
   */
  protected function applyPrioritiesToPatterns()
  {
    foreach ($this->_patterns as $pattern => $pattern_data)
    {
      if ($this->isProrityPattern($pattern))
      {
        $this->movePatternToTop($pattern);
      }
    }
  }
  /**                                                                                                                                                                                
   * Parses the array to cache and creates the PHP string to write to disk                                                                                                           
   *                                                                                                                                                                                 
   * @return string the PHP string to save into the cache file                                                                                                                       
   */
  protected function _buildCache()
  {
    $this->applyPrioritiesToPatterns();
    return parent::_buildCache();
  }
}

[quentin389]

Hi, sorry for the delay.

It's not a simple issue... please read this: browscap/browscap#33

So unfortunately I have to fix problems like that separately for each erroneous match :|

And that means, that the idea of adding an optional priority that overrides the automatic order makes a lot of sense.

I can't promise when I'll look at the code and implement it, but I'm keeping this issue in mind.