Possible issue with ShapeVector::setSize? about torque2d

[lilligreen]

Sorry, didn't realize you can't attach code to an issue. Created a pull request - issue 44 to replace this one.

[lilligreen]

On second thought, pull request 44 only has toy updates and not a fix to this, so I will keep them as two separate items. Sorry for the confusion.

[doodaddy64]

Are you saying there is an issue with radius that requires an engine fix but that your pull-request is not that fix?

[lilligreen]

Yes, pull request 44 is only an update to ShapeVectorToy with improvements. While testing my version of ShapeVectorToy I noticed that setCircleRadius is not actually setting the radius, but the diameter of a ShapeVector circle. Unfortunately I do not know C++ to fix this myself, so I can only report it.

[crabmusket]

Are you sure the radius is setting the diameter? I'm looking at this code in ShapeVector::renderCircleShape:

    for (int32 i = 0; i < k_segments; ++i)
    {
        Vector2 v = position + radius * Vector2(cosf(theta), sinf(theta));
        glVertex2f(v.x, v.y);
        theta += k_increment;
    }

This seems to use radius correctly, and it's passed directly from mCircleRadius, which is what you set when you touch CircleRadius in script. You mentioned that a circle of radius 2 fits inside a box of size 2 - are you sure the 2 is not the radius of the box as well?

[crabmusket]

However, I did find this in ShapeVector::setPolyPrimitive:

    // Special-Case Quad?
    else if ( polyVertexCount == 4 )
    {
        // Yes, so set Quad.
        mPolygonBasisList[0].Set(-1.0f, -1.0f);
        mPolygonBasisList[1].Set(+1.0f, -1.0f);
        mPolygonBasisList[2].Set(+1.0f, +1.0f);
        mPolygonBasisList[3].Set(-1.0f, +1.0f);
    }

Compare that to the old script from the toy:

        case "Square":
            %points = "-0.5 -0.5 0.5 -0.5 0.5 0.5 -0.5 0.5";

Seems that the new code and old code are behaving slightly differently. Using setPolyPrimitive, you get a square of radius 20, but in the old code it was diameter 20.

[lilligreen]

Ok, I did some more testing in Torquescript. Looks like the issue is with setSize for ShapeVectors.

To the left is a ShapeVector with a size of 20 and to the right a scene object with a size of 40 (AABB turned on for both). Is this a bug or is there a reason that the size property is different for ShapeVectors compared to SceneObjects?

[MichPerry-GG]

I went ahead and resolved the issue in revision ce0e10f.