Comments (4)
which constants should be in this file?
from enrico.
There's a few dozen numbers that are used in many different places ... here's just some examples:
met_ref = 240106987.-23*60.-6
mdj_ref= 54689.
return 1.602e-6 * energies ** 2 * err #Mev to Ergs
ghcount = ROOT.TH2F("ghcount", "", 80, min(E)*0.3,max(E)*2, 100, 0.1, max(obs) * 2)
tool['dcostheta'] = 0.025
Keeping them in one place and giving them names will reduce errors and simplify maintenance, e.g. we'll use
# in constants.py
MEV_TO_ERG = 1.602e-6
# somewhere else
from enrico.constants import MEV_TO_ERG
return MEV_TO_ERG * energies ** 2 * err
Agreed?
I can make a PR and you can review it, but we should do such cleanup after outstanding changes have been merged or we'll be in merge conflict hell.
from enrico.
agreed. I will do it in my next pull. I will do the same for the names of folders
from enrico.
done
from enrico.
Related Issues (20)
- Fermitools migrated to Python3
- LC issue - cannot do a non-empty take from an empty axes HOT 2
- enrico_sed issue: Error in "Preparing submission of fit into energy bins" HOT 22
- issue with IRF HOT 2
- Problems with enrico_lc HOT 14
- enrico_sed- ImportError: libCLHEP-2.4.4.0.so: cannot open shared object file HOT 1
- error enrico_plot_lc HOT 1
- Problems with enrico_sed HOT 1
- It's possible use GPU to analize light curves with Enrico? HOT 1
- error with enrico_sed HOT 13
- General Query HOT 3
- enrico_sed error
- Issue_enrico_lc
- installation problem in Mac air HOT 2
- regarding the installation of prerequisites package "Kapteyn" HOT 1
- error while doing unbinned likelihood analysis HOT 5
- Error in Diffusive response step with enrico_sed HOT 1
- error related to scfile HOT 1
- Related to computing variability index in Enrico_lc task
- Problem in enrico_sed: Preparing submission of fit into energy bins
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enrico.