Coder Social home page Coder Social logo

Comments (7)

hinok avatar hinok commented on June 8, 2024 1

@wallzero I had to also specify context for generic-names like

createGenerator('[local]-[hash:base64:5]', { context: 'src/client' }),
//                                               ^
//                                               |
//                                               |
//                                               |
//                   Without { context } it didn't work correctly

So now my babel.config.js looks +/- like below

const createGenerator = require('generic-names');

// ... later in the code where plugins are defined


[
    'react-css-modules',
    {
      context: 'src/client',
      filetypes: {
        '.scss': {
          syntax: 'postcss-scss',
          plugins: [
            [
              'postcss-nested',
              {
                bubble: ['@include'],
                preserveEmpty: true,
              },
            ],
          ],
        },
      },
      generateScopedName: createGenerator('[local]-[hash:base64:5]', { context: 'src/client' }),
      webpackHotModuleReloading: env === 'development',
      exclude: 'node_modules',
      handleMissingStyleName: 'throw',
    },
  ]

Hopefully it will help somebody.
The context options is also mentioned in #279 (comment)

from babel-plugin-react-css-modules.

PieNam avatar PieNam commented on June 8, 2024

But still, the best way to solve this is an update of this package. LOL 😂

from babel-plugin-react-css-modules.

wallzero avatar wallzero commented on June 8, 2024

I just gave this a try and the hash in the JSX still failed to match the hash in the generated CSS. I tried with latest generic-names and css-loader. Mind you I am using a custom localIdentName which matches my generateScopedName: [local]-[hash:6].

from babel-plugin-react-css-modules.

PieNam avatar PieNam commented on June 8, 2024

I just gave this a try and the hash in the JSX still failed to match the hash in the generated CSS. I tried with latest generic-names and css-loader. Mind you I am using a custom localIdentName which matches my generateScopedName: [local]-[hash:6].

Sorry to hear that. Have you checkout the name-generator of css in your builder like webpack to see if its using the newest generic-names?

from babel-plugin-react-css-modules.

PieNam avatar PieNam commented on June 8, 2024

I've found out an approach that is more decent with yarn.
If you're using yarn as your package manager, try resolutions property in the package.json like:

{
  "resolutions": {
    "generic-names": "^3.0.0"
  },
}

This force all packages in node_modules to use generic-names in version 3, which ensure that the babel-plugin are using the same name generator with the builder (css generator).

from babel-plugin-react-css-modules.

wallzero avatar wallzero commented on June 8, 2024

I am not using yarn but instead I tried npm-force-resolutions and confirmed generic-names@^3 with npm list generic-names. Even forcing the latest version on all packages and ensuring the same generateScopedName is used, the hashes still don't match. Furthermore, I am using a shared Webpack configuration and resolutions would need to be added to every downstream project.

For now I am just sticking with css-loader@^3.6.0.

from babel-plugin-react-css-modules.

wallzero avatar wallzero commented on June 8, 2024

@hinok Thanks! I hadn't mentioned I had used the context parameter and I still couldn't get it to work. Although maybe it will help someone else. Like I said, I am using a shared configuration between projects and requiring downstream projects to resolve generic-names isn't an option. Perhaps the shared configuration may also be why setting context was not working?

For now I am using the fork @dr.pogodin/babel-plugin-react-css-modules and it is working well.

from babel-plugin-react-css-modules.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.