Comments (18)
default.svg.zip
Hello notruck, the svg file is here, the grid line I think is just good, if it is thinner than the present width, the effect are not very good, but you can modify the line width in the code directly based on your favorite.
from cutechess.
Hello notruck, this is the eventual effect of Sittuyin chess.
from cutechess.
I have open a PR to the official repo. please be patient as the repo maintainer of cutechess ilaripih has an excellent solution to improve the code quality.
from cutechess.
I have found a workaround to settle this.
from cutechess.
Hello notruck, the regional favor board for Makruk and Sittuyin is not a unimplementable feature. I am very curious about how you get the Xiangqi and Janggi board I painted in the process of implementation of them from cjssh1002. I think cjssh1002 do the right thing to tell you about it as the cutechess is open source project, which encourages everybody who love chess and/or the chess variant to get access to it.
I add an parameter to the Graphicsboard class that makes painting various board possible. As to the regional favor pieces, in fact there need some additional modification to the piece which is not central symmetric, the modification to these kind piece should be performed which make its displayed center be coincident to the square center.
Another problem is that if the different size of the piece which should be displayed the margin should be added to the original designed piece, if not the displayed pieces will be identical sized when displayed on the board as the auto-scaling feature to fit the square size of the current design. Just like the pieces displayed on the Janggi board, though it is designed in different size, but the auto scaling feature the cutechess owned makes it identical sized on the board, the modification should be performed to take into the autoscale feature.
From the above discussion, we can say that the pieces of Sittuyin will have very good display effect, it is almost identical to the board in the above picture. But the Makruk is not the case without the modification to the non center symmetric pieces.
As far as now, I am not skilled at graphics design, I did not have the ability to do the desired modification to the pieces that achieve the best display effect of Makruk.
I will paint the Makruk and Sittuyin regional favor board when I have time and open a pull request to the official repo to avoid the fragile development of cutechess.
from cutechess.
Thanks for the detailed explanations! I didn't realize about the (auto)-scaling aspect at all. I'll ask Fulmene if the necessary modifications can be made for the Makruk pieces.
I learned about the Janggi developments in progress for cutechess , as cjssh1002 was testing and discussing some uci settings with the Fairy-Stockfish engine's author Fabian, on the pychess players discord server. I've already known about cutechess, having used it before for a number of the existing variants. As I expressed interest and excitement about the upcoming new features, they both kindly told me more about it, and readily provided the relevant links. Thanks to them, I have discovered this fork of cutechess. 😁
from cutechess.
I have finish the regional favor board painting in the cutechess. But all the pieces are deformed due to the auto-scaling, the modification to the pieces is needed.
from cutechess.
from cutechess.
Wow, thanks! The Makruk pieces fared better than I thought.
Those Sittuyin pieces are from @ka-hu btw. I think some were modifications of Couch Tomato's existing pieces, while others were made from scratch. They're also under CC-BY-4.0
But yeah, it seems all three sets could use some (re)scaling love. 😁
from cutechess.
This is the final effect after my adjust to the height and width ratio of every piece.
It is far from perfect, but close to the picture you posted. If you have any suggestion, please feel free to point out, thank you, or I will open a pull request to the official repo
from cutechess.
They look much better now. Thanks!
Could the grid lines be made a little bit thinner?
May I take a look at the current svg you have? Not that I know how to adjust them properly, but I'd like to see if there's anything I can try, as well as something the original artists might be able to help with.
But if the edits aren't trivial, maybe it's best to go ahead and open the official PR.
from cutechess.
Alright, let's go with the current grid line widths then. Just one more thing, the Sittuyin knights seemed to look better in the earlier screenshots. Should we revert them?
from cutechess.
The answer is definitely yes, I have uploaded the svg file in the previous post, you can modify it in your favorite way. But I guess that you also prefer to adjust the height and width ratio of the Elephant(Bishop).
from cutechess.
Oh yeah, I forgot about the Elephants. The Rooks, Knights, and Elephants are all looking good now! The General is probably the right size already. The King could be bigger, and the pawns smaller. But if that's too much trouble to adjust them any further, I'd say they're ready for the PR.
Thank you so much for this!
from cutechess.
Hello notruck, the different sized piece is a feasible feature just like janggi, but it is not realizable as the auto-scaling feature in cutechess. when I get the skill to tackle this issue someday, I will bring it to reality, but is is not now.
from cutechess.
I see, I'd like to compile and try it out please. Where may I find the latest changes you've made to enable the new Makruk and Sittuyin boards and pieces?
from cutechess.
Hello notruck, I will open a pull request to the official repo and you can fetch the code after I do it.
from cutechess.
Hello notruck, there is a side effect that the visual effect of Ai-work is a little weird compared to the former format.
Do you have any suggestion?
from cutechess.
Related Issues (14)
- Janggi - Accurate understanding of the same move 3 times HOT 5
- Janggi openingbook error HOT 1
- Cute janggi win/loss bug (After using the pass) HOT 1
- cutechess 1.20 Merge request HOT 1
- There is a bug that cannot be moved HOT 2
- Issue when installing Cuteches Xiangqi in Windows 10 HOT 2
- An accurate understanding of Janggi "bikjang". HOT 8
- "Cute Janggi" move notation problem and game save&load error. HOT 5
- Korean game notation method is needed HOT 3
- What's wrong with compilation? I can't solve it.
- Windows Compilation Help Request
- To do list for Janggi HOT 1
- Openingbook playback issue HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cutechess.