Why is User considered modified on sign in? about gae-init

[mdxs]

Is this due to the user_db.put_async() call inside signin_user_db(user_db) in auth.py?

[mdxs]

Just noticed that 6f5143f introduced the put_async() call; was this to record some kind of "last login" via modified or was it needed to catch some pending updates (that should be dealt with elsewhere)?

[lipis]

Yes.. It was the easiest way of the last seen thing and no pending updates.

[mdxs]

Hmm, I don't like the user modified simply from having logged on... in my opinion that should go into some audit trail (if an app needs that detail), while the user.modified should be reserved for actual changes to the user account/profile in that user record. But I'll sort that out in my own stuff (first). From commenting out the put_async() locally, I didn't see any bad behaviour... but that could be a lack of proper testing on my side. Is there a particular case/procedure you're aware of that it covers?

[lipis]

I have to admit that is not the most accurate one for last seen thingy but in a way it is.. (unless you have the remember flag on)

I didn't want to introduce new properties or anything like that so the easiest way to do that without even affecting the performance is to do it asynchronously.. so if you are about to remove it simple delete that line and also the @ndb.toplevel decorator... more on that in the docs.. https://developers.google.com/appengine/docs/python/ndb/async#intro

[mdxs]

Excellent, thanks for the feedback and clarification; I've no problem for gae-init keeping things simple to get people started quickly. Not having a "last seen" feature might make it even simpler :-)

But hey, it made me learn something; so thanks!

[lipis]

The simplest thing would be not having the user sign in at all.. :D but
like you said you learned something and it's not very intruding.. and this
line made you actually act on it in your real life project which is the
whole point..! People should go ahead and change these kind of stuff to
match their needs..

[lipis]

Soon you might find more hidden easter eggs in the project.. it's full of small little things :)

[mdxs]

!!1

[lipis]

hehe... nice one.. stolen from Google :)
http://www.google.com/stolen