Minification bug and suggestions. about gae-init

[mdxs]

I'm still learning about Grunt and the rest of the toolchain, so I lack a strong opinion on this topic. If I look at the run.py script, I would think it could also be solved adding a dict/set and using that to check against dupes... but that obviously isn't the Grunt magic you're looking for.

[lipis]

@topless I also like Grunt and I think it's a pretty cool tool! For the gae-init though there are some requirements that I really don't want to drop just to use Grunt and if there is a nice and clean way to achieve these requirements I'm willing to simplify the run.py script.. Stuff like combining .coffee and .js files and you're not tied to use only CoffeeScript...

[lipis]

But if there is a viable clean and nice solution when someone can change the file structure in one single file and everything will work smoothly locally and on production.. we could have a second look on that issue.. until then I don't have much time to spend on that one.. plus the run.py works like a glove...

[mdxs]

Quick look around shows that https://github.com/gruntjs/grunt-contrib-uglify might work with https://github.com/mishoo/UglifyJS2

Where UglifyJS2 seems to be a newer version than currently found in gae-init/node_modules/uglify-js (at least it seems from my limited observation)

[gmist]

    'scripts': list({
        'src/script/common/util.coffee',
        'src/script/common/service.coffee',
        'src/script/common/upload.coffee',

        # Add this duplicate entry below
        'src/script/site/app.coffee',
        'src/script/site/app.coffee',
        ....
    })

:)

[mdxs]

Yep, seems better than my suggestion to mess with run.py :-)

[mdxs]

Though the order specified is no longer guaranteed... does that matter for the JS?

[lipis]

I think the order on that stage doesn't really matter.. but maybe it is :) Either case having a duplicate entry is a developer's issue anyway.. I mean people should be a little bit more careful and especially with the copy/paste programming..! :P So for me that's not a real issue and I think @topless is just vouching for dumping the run.py script in favour of Grunt for compilation/minifications...

[mdxs]

Okay.

To preserve order, one could use:

def uniq(lst):
  dct = {}
  return [dct.setdefault(e, e) for e in lst if e not in dct]

after which:

    'scripts': uniq([
        'src/script/common/util.coffee',
        'src/script/common/service.coffee',
        'src/script/common/upload.coffee',

        # Add this duplicate entry below
        'src/script/site/app.coffee',
        'src/script/site/app.coffee',
        ....
    ])

Could do the trick.

Or to protect the innocent, the uniq() approach could be added to run.py to help the copy-and-paste wizards. So that they can continue to make a mess in main/config.pyand it still works ;-)

[lipis]

I would prefer the http://stackoverflow.com/a/480227/8418 set solution rather than the .setdefault but still it's the same idea.. might add that in the run.py eventually..

[mdxs]

See pull #42 (the answer to everything...)

[lipis]

I'm closing this one since the bug was solved. As for the suggestion I want to see it working first in a different project and we'll see how this is going to fly...