merge_user_dbs - parameter 'user_db' is not used about gae-init

[joernhees]

yes, i think that's intentional as the method is a skeleton meant to be filled with merging logic depending on the final app. see discussion in #62

[lipis]

yep it's intentional.. as some people might want to do something extra after the merge to the given user_db..

[joernhees]

maybe we could update the comment so it's a bit clearer that this is not a left TODO for us but for the developer using gae-init?
# TODO: if you want to handle user data for merged users, do it here!

[gmist]

it is not obvious... maybe something like this

def merge_user_dbs(deprecated_keys, user_db=None, post_func=lambda u: u):
  deprecated_dbs = ndb.get_multi(deprecated_keys)
  for deprecated_db in deprecated_dbs:
    deprecated_db.auth_ids = []
    deprecated_db.active = False
    if not deprecated_db.username.startswith('_'):
      deprecated_db.username = '_%s' % deprecated_db.username
  ndb.put_multi(deprecated_dbs)
  post_func(user_db)

usage by default

deprecated_keys = [key for key in user_db_keys if key != merged_user_db.key]
merge_user_dbs(deprecated_keys)

with extra something

deprecated_keys = [key for key in user_db_keys if key != merged_user_db.key]
merge_user_dbs(deprecated_keys, merged_user_db, lambda u: u.key.delete())

or

def something(user):
  user.key.delete()
deprecated_keys = [key for key in user_db_keys if key != merged_user_db.key]
merge_user_dbs(deprecated_keys, merged_user_db, something)