Argument 'ignore' is mutable about gae-init

[gmist]

and one more thing - argument list shadows built-in list

[lipis]

Nice ones :) the list should become is_list and as for the ignore I just wanted to indicate that it's a list.. what's the best approach to that?

[gmist]

docstring + raise ValueError if type(ignore) not list - 100% bulletproof approach :)

[lipis]

or maybe for the ignore we could accept comma separated strings or a list and by default set it to None and then inside the function something like this:

ignore = ignore.split(',') if isinstance(ignore, str) else ignore or []

[gmist]

ignore is not changed in function, may just be use tuple ignore=()?

[lipis]

With the above line it could be a tuple as well.. it's just in most cases it will be one argument.. is it too ugly to be able to accept anything and handle it inside the function?! Is stupid to have a comma in the argument name anyway (if at all possible)

[gmist]

I agree, comma splitting string and ignore=None by default - it is the more elegant decision.