HTTPretty overwrites socket.inet_aton method globally. about httpretty

[razzmatazz]

We are currently using this patch to make it work (i.e. to make the disable()/enable() properly restore socket.inet_aton)

Note that this patch does not fix the other underlying issue of socket.inet_aton() not working properly when socket is patched, which was mentioned by @dotpot. It just makes 'unpatching/disabling' to work properly.

--- a/venv/lib/python2.7/site-packages/httpretty/core.py    2013-05-29 16:01:51.000000000 +0300
+++ b/venv/lib/python2.7/site-packages/httpretty/core.py    2013-05-29 16:02:19.000000000 +0300
@@ -68,6 +69,7 @@
 old_gethostbyname = socket.gethostbyname
 old_gethostname = socket.gethostname
 old_getaddrinfo = socket.getaddrinfo
+old_inet_aton = socket.inet_aton
 old_socksocket = None
 old_ssl_wrap_socket = None
 old_sslwrap_simple = None
@@ -696,7 +708,7 @@
         socket.gethostname = old_gethostname
         socket.gethostbyname = old_gethostbyname
         socket.getaddrinfo = old_getaddrinfo
-        socket.inet_aton = old_gethostbyname
+        socket.inet_aton = old_inet_aton

         socket.__dict__['socket'] = old_socket
         socket.__dict__['_socketobject'] = old_socket
@@ -706,7 +718,7 @@
         socket.__dict__['gethostname'] = old_gethostname
         socket.__dict__['gethostbyname'] = old_gethostbyname
         socket.__dict__['getaddrinfo'] = old_getaddrinfo
-        socket.__dict__['inet_aton'] = old_gethostbyname
+        socket.__dict__['inet_aton'] = old_inet_aton

         if socks:
             socks.socksocket = old_socksocket

[CyrilRoelandteNovance]

I think this has been fixed by a2d6dfc . Closing.