Coder Social home page Coder Social logo

Duplicate Log Lines about castsponsorskip HOT 5 CLOSED

gabe565 avatar gabe565 commented on June 8, 2024
Duplicate Log Lines

from castsponsorskip.

Comments (5)

gabe565 avatar gabe565 commented on June 8, 2024

I haven't seen this one. I'm glad it doesn't affect the experience, but I'd like to fix it. Do you know if this started in v0.4.0 or in v0.4.1? Also, could you try to replicate with CSS_LOG_LEVEL=debug?

from castsponsorskip.

gabe565 avatar gabe565 commented on June 8, 2024

When this happens, does the sponsorship actually get skipped? After looking at your logs some more, it seems like the skip command fails for some reason causing it to try repeatedly. This is intended, but the sponsorship should either get skipped or an error should appear so I'm not sure why neither is happening. Is this on your Chromecast Ultra?

from castsponsorskip.

QueenLinuxGlitch avatar QueenLinuxGlitch commented on June 8, 2024
  1. Started back in 3.0 actually, but generally skipped segments and was incredibly sporadic
  2. Usually, the video ends up not having a sponsor segment anyway, and/or I never saw it, didn't watch the whole video e.g.
  3. Yup, on my Chromecast Ultra w/ Google TV

On next run, will up log level to debug and report results

EDIT: Results good so far, just a few videos in, will have more results by tomorrow night

EDIT 2:
time=2023-09-07T23:39:54.091-05:00 level=INFO msg="Video ID not found. Searching for video on YouTube..." device="Living Room TV"
time=2023-09-07T23:39:54.091-05:00 level=DEBUG msg="Searching for video ID" query=""TLDR Business"+intitle:"Is Going Woke Killing Disney... we ran the maths""
time=2023-09-07T23:39:54.438-05:00 level=INFO msg="Detected video stream." device="Living Room TV" video_id=5SybR3KiBMw

I thought it was supposed to be Cast Metadata Detection then Channel + title query as failover, in my results I'm seeing both, not an issue, just a misunderstanding of logic

EDIT 3:
time=2023-09-07T23:58:37.838-05:00 level=DEBUG msg=Update device="Living Room TV"
time=2023-09-07T23:58:37.853-05:00 level=INFO msg="Skipping to timestamp." device="Living Room TV" category=sponsor from=14m19s to=15m20s
time=2023-09-07T23:58:38.338-05:00 level=DEBUG msg=Update device="Living Room TV"
time=2023-09-07T23:58:38.351-05:00 level=INFO msg="Skipping to timestamp." device="Living Room TV" category=sponsor from=14m20s to=15m20s

Duplicate Skip, everything worked fine on the TV end, but log shows double

from castsponsorskip.

gabe565 avatar gabe565 commented on June 8, 2024

I thought it was supposed to be Cast Metadata Detection then Channel + title query as failover, in my results I'm seeing both, not an issue, just a misunderstanding of logic

No, that's correct. Most devices set the video ID in the metadata, but some don't. For the devices that don't, querying YouTube is the fallback.

Duplicate Skip, everything worked fine on the TV end, but log shows double

Thanks for posting that! It still seems like the initial skip is failing for some reason. Or maybe the device isn't returning the new timestamp immediately? Interesting either way.

from castsponsorskip.

gabe565 avatar gabe565 commented on June 8, 2024

@QueenLinuxGlitch Are you still seeing this behavior? I have a feeling this is just due to the update interval being twice per second. It seems like it tries to skip twice before it actually gets an update back from the device. I could make it not try to skip the segment twice in a row, but I'd prefer to avoid doing that to keep the code simpler. What do you think?

from castsponsorskip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.