Comments (5)
Well, it relies on the @dump
messages configured in your tune settings. On hope island:
Dumping...
## Please stand by, database save in progress. ##
## Database save is complete. ##
I think hope is using inline dump, so this behavior might be different in the case of a forked dump (i.e. a dump that doesn't pause the MUCK while it is running). So are your dumps working like Hope and your messages are not sufficient so you want an additional "Done"? Or are you using an async dump and not getting these messages?
from fuzzball.
I was incredibly vague when I originally opened this issue. The messages in @tune
get sent to everyone. What I would like is a "dump complete" confirmation to be sent to the invoker of @dump
, but no one else.
from fuzzball.
Gotchya. That is weirdly complicated because, as I recall, once @dump
forks, it loses all sense of who made the initial call. That said, we should be able to carry a triggering person ref along for the ride, so I'll see what we can do here.
from fuzzball.
In researching this, I have learned there's a MUF event called 'DUMP' that is triggered when a dump is complete. I don't know if that is interesting or not. It appears to be the only time something like this is done in the codebase that I can easily tell. Of course, this event won't tell you who triggered the dump.
How dump notifications work is really sketchy. We fork the dump process then collect it later, but when we collect it, we flag that we need to notify rather than do the notify there. I COULD put the "dump complete" notification there, but then it will always show up before the global notification.
I've chosen instead to put the "dump complete" notification in the same code block as the global notification. This is both what would be expected by future developers I think, but also makes sure "dump complete" shows up after the global notification which I think is nicer. However, it technically introduces a race condition where someone could "steal" your dump complete message. I.e. you trigger a dump, then another wizard triggers a dump at the exact millisecond the first completes, then the other wizard could theoretically steal your complete message.
However, I think simplicity and logical layout is more important than solving for a nearly impossible to happen edge case. That said, I think the real right answer is to move the notification into the signal handler, but I don't think it is important enough to do the surgery or even really recommend doing the surgery at this time.
from fuzzball.
@astarafar This should do it for you, let me know if you have any problems.
from fuzzball.
Related Issues (20)
- Idea: Program Blessing (SF issue) HOT 1
- Queue pid not watchable immediately (SF issue)
- cmd-page allows wizard-owned puppets to page (SF issue) HOT 2
- descr_setuser disconnect loop crash (SF issue)
- Forcing a wiz to @toadplayer (SF Issue) HOT 3
- Forward referencing in MUF (SF Issue) HOT 1
- page #standard doesn't make pages received in the standard format (SF Issue)
- Use C++ Where Helpful
- Cleanup TODO's
- Fix Docker Issues HOT 3
- MUCK sudo command
- Appveyer Build Failure for Windows HOT 1
- Add allowing registration on login screen by @tune HOT 2
- Review and Document Listener Behaviour HOT 4
- {contents} MPI function does not behave as documented / nonsense exits behavior HOT 1
- READ from MUF called on Welcome Screen causes oddities HOT 1
- {force} allows escape character in input HOT 2
- Use XML to store helpfile content
- Make users always have a new dbref HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fuzzball.