Global scope (room zero) exit is taking priority over a local scope exit when exit priorities are equal. about fuzzball

Confirmed. The local scope action is selected when trying to execute the action, but anything involving name matching is selecting the global scope action instead of the local one whenever the priority values are equal.

[wyld-sw]

Could be an unintended side effect of commit bc98723. I’m not by a computer today, so if you’re in a position to revert the commit, I’d appreciate the testing! Either way, I’ll be able to look at it sometime tomorrow.

If I remember correctly, SPR’s previous compile date was July 6? If that’s right, that commit seems to be the only one affecting matching. But I only looked briefly.

Sorry for the inconvenience :(

That appears to have partially solved the issue, but this gets a little more strange now.

With that commit reverted, if I try to examine a player that has a name that conflicts with a global scope exit, I will either get the global scope exit, or the local player, and it's random as to which one I get.

@muf "PlayerName" match repeated ten times:

Program compiled successfully.
[%] Result: #231
Program compiled successfully.
[%] Result: #174407
Program compiled successfully.
[%] Result: #174407
Program compiled successfully.
[%] Result: #174407
Program compiled successfully.
[%] Result: #231
Program compiled successfully.
[%] Result: #174407
Program compiled successfully.
[%] Result: #231
Program compiled successfully.
[%] Result: #174407
Program compiled successfully.
[%] Result: #231
Program compiled successfully.
[%] Result: #231

Apparently, this issue has existed for quite some time. So not as critical.

Update: Apparently, this issue is present on FM as well.

[wyld-sw]

Great. I’ll officially revert that commit tomorrow. I ran into the same issue, on mucks with the “delimiter” command: by repeatedly issuing the “;” command, it was random what would actually execute.

Thanks for reminding me of it. The matching routine for exits and contents DOES randomly choose one if there are two equally named choices. If there’s not much more to it, perhaps it should favor a local exit.

[wyld-sw]

More specifically, choose_thing() needs to choose the more local before tossing a coin.

That was my thinking. In our case, the player was the local thing for "examine," and it would select the local player or the global exit randomly. Thanks!

[wyld-sw]

Commit reverted. Locality check should be in an upcoming fix.